[GitHub] [maven-resources-plugin] pzygielo commented on a change in pull request #5: try with resources

[GitBox <gi...@apache.org>]

pzygielo commented on a change in pull request #5:
URL: https://github.com/apache/maven-resources-plugin/pull/5#discussion_r456444223



##########
File path: src/test/java/org/apache/maven/plugins/resources/stub/MavenProjectBuildStub.java
##########
@@ -300,8 +293,6 @@ private void populateFile( File file ) throws IOException
             try ( FileOutputStream outputStream = new FileOutputStream( file ) )
             {
                 outputStream.write( data.getBytes() );
-                outputStream.flush();

Review comment:
       I think @roxspring is right about FOS not wrapped in BOS not being problem for flushing or not. But I'm not sure that
   > close also flushes
   
   is true. There is `flush` called in `FOS.finalize` but `close` inherited from `OutputStream` is no-op.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org