You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "carloea2 (via GitHub)" <gi...@apache.org> on 2026/08/31 01:58:19 UTC
[PR] fix(pyamber): keep empty Iceberg ranges empty [texera]
carloea2 opened a new pull request, #8194:
URL: https://github.com/apache/texera/pull/8194
### What changes were proposed in this PR?
Treat only a missing Iceberg range end as unbounded. Preserve an explicit zero end so the documented half-open range from zero to zero remains empty.
Before: get_range(0, 0) computed an infinite limit and could return every row.
After: get_range(0, 0) computes a zero limit and returns no rows. Unbounded get and get_after behavior is unchanged.
### Any related issues, documentation, discussions?
Closes #8193
### How was this PR tested?
Regression test first:
$env:PYTHONDONTWRITEBYTECODE='1'; C:\Users\carlo\texera\texera\.venv312\Scripts\python.exe -c "import sys,pytest; sys.path[:0]=[r'C:\Users\carlo\texera\texera-worktrees\fix-pyamber-empty-iceberg-range\amber\src\main\python',r'C:\Users\carlo\texera\texera\amber\src\main\python']; raise SystemExit(pytest.main([r'amber\src\test\python\core\storage\iceberg\test_iceberg_document.py::TestIcebergDocumentWithMockCatalog','-q','-p','no:cacheprovider']))"
Before the source change: 13 passed and 1 failed. The new regression returned an injected row from the empty range.
After the fix: 14 passed.
C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe check amber/src/main/python amber/src/test/python
C:\Users\carlo\texera\texera\.venv312\Scripts\ruff.exe format --check amber/src/main/python amber/src/test/python
Result: all checks passed and 213 files were already formatted.
The production iterator probe used the same controlled record source before and after the change. Before, the zero end produced an infinite limit and returned the row. After, it produced a zero limit and an empty result.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex, GPT-5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): keep empty Iceberg ranges empty [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8194:
URL: https://github.com/apache/texera/pull/8194#issuecomment-5472764845
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@mengw15`, `@aglinxinyuan`
You can notify them by mentioning `@mengw15`, `@aglinxinyuan` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): keep empty Iceberg ranges empty [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8194:
URL: https://github.com/apache/texera/pull/8194#issuecomment-5472764506
<!-- backport-auto-label-report -->
### Backport auto-label report
This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
| Release branch | Analysis |
| --- | --- |
| ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`amber/src/main/python/core/storage/iceberg/iceberg_document.py`, `amber/src/test/python/core/storage/iceberg/test_iceberg_document.py`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
| ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
_[Auto-label run](https://github.com/apache/texera/actions/runs/33349196689)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): keep empty Iceberg ranges empty [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8194:
URL: https://github.com/apache/texera/pull/8194#issuecomment-5472788959
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8194?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 93.94%. Comparing base ([`70c2114`](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0f00c4f`](https://app.codecov.io/gh/apache/texera/commit/0f00c4f37ca135f3ff140ca3c85f220024721273?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8194 +/- ##
============================================
- Coverage 93.94% 93.94% -0.01%
Complexity 4759 4759
============================================
Files 1185 1185
Lines 48069 48069
Branches 5359 5359
============================================
- Hits 45159 45157 -2
- Misses 1480 1482 +2
Partials 1430 1430
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.00% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.32% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `89.99% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.86% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.91% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.49% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.31% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.83% <ø> (-0.05%)` | :arrow_down: | |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8194/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.19% <ø> (ø)` | | Carriedforward from [70c2114](https://app.codecov.io/gh/apache/texera/commit/70c21145887920528d7d5540e3fb790b43e8b759?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8194?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(pyamber): keep empty Iceberg ranges empty [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8194:
URL: https://github.com/apache/texera/pull/8194#issuecomment-5472812553
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 2 better · 🔴 2 worse · ⚪ 11 noise (<±5%) · 0 without baseline
> Compared against main `70c2114` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/33349206931)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 391 | 0.239 | 24,351/33,174/33,174 us | 🟢 -11.3% / 🔴 +124.3% |
| 🔴 | bs=100 sw=10 sl=64 | 786 | 0.48 | 122,979/178,796/178,796 us | 🔴 +23.7% / 🔴 +77.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 913 | 0.557 | 1,093,325/1,175,777/1,175,777 us | ⚪ within ±5% / 🔴 +21.5% |
<details><summary>Baseline details</summary>
Latest main `70c2114` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 391 tuples/sec | 392 tuples/sec | 844.57 tuples/sec | -0.3% | -53.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.239 MB/s | 0.239 MB/s | 0.515 MB/s | 0.0% | -53.6% |
| bs=10 sw=10 sl=64 | p50 | 24,351 us | 24,917 us | 11,837 us | -2.3% | +105.7% |
| bs=10 sw=10 sl=64 | p95 | 33,174 us | 37,383 us | 14,788 us | -11.3% | +124.3% |
| bs=10 sw=10 sl=64 | p99 | 33,174 us | 37,383 us | 17,651 us | -11.3% | +87.9% |
| bs=100 sw=10 sl=64 | throughput | 786 tuples/sec | 826 tuples/sec | 1,084 tuples/sec | -4.8% | -27.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.48 MB/s | 0.504 MB/s | 0.662 MB/s | -4.8% | -27.5% |
| bs=100 sw=10 sl=64 | p50 | 122,979 us | 121,769 us | 94,505 us | +1.0% | +30.1% |
| bs=100 sw=10 sl=64 | p95 | 178,796 us | 144,509 us | 100,941 us | +23.7% | +77.1% |
| bs=100 sw=10 sl=64 | p99 | 178,796 us | 144,509 us | 108,642 us | +23.7% | +64.6% |
| bs=1000 sw=10 sl=64 | throughput | 913 tuples/sec | 918 tuples/sec | 1,119 tuples/sec | -0.5% | -18.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.557 MB/s | 0.561 MB/s | 0.683 MB/s | -0.7% | -18.5% |
| bs=1000 sw=10 sl=64 | p50 | 1,093,325 us | 1,086,811 us | 924,404 us | +0.6% | +18.3% |
| bs=1000 sw=10 sl=64 | p95 | 1,175,777 us | 1,173,370 us | 967,785 us | +0.2% | +21.5% |
| bs=1000 sw=10 sl=64 | p99 | 1,175,777 us | 1,173,370 us | 995,630 us | +0.2% | +18.1% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,511.64,200,128000,391,0.239,24350.56,33174.31,33174.31
1,100,10,64,20,2544.23,2000,1280000,786,0.480,122978.88,178795.75,178795.75
2,1000,10,64,20,21917.25,20000,12800000,913,0.557,1093324.84,1175776.74,1175776.74
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org