You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/09/19 17:49:45 UTC
[GitHub] flink pull request #4684: [FLINK-7603][savepoint/doc] Document how to take a...
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4684
[FLINK-7603][savepoint/doc] Document how to take a savepoint on YARN
## What is the purpose of the change
The documentation should have a separate entry for savepoint related CLI commands in combination with YARN. It is currently not documented that you have to supply the application id, nor how you can pass it.
## Brief change log
- *add instruction of taking savepoints on YARN to both Savepoint and CLI doc*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4684
----
commit 6386983239bd3024b395c865ec4fd33e232ca5a3
Author: Bowen Li <bo...@gmail.com>
Date: 2017-08-30T16:35:03Z
FLINK-7422 Upgrade Kinesis Client Library (KCL) and AWS SDK in flink-connector-kinesis
commit 381cd4156b84673a1d32d2db3f7b2d748d90d980
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-07T06:33:37Z
Merge remote-tracking branch 'upstream/master'
commit dcf40bd821187b848d924f7f4df6805b1b924c16
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-15T18:00:03Z
Merge remote-tracking branch 'upstream/master'
commit 169ea0a3bee1ba315d39fa49c16e9bd7c71d1338
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-18T06:25:26Z
Merge remote-tracking branch 'upstream/master'
commit 659e91c18ade8eb65d355b5b85ae2d402a61ff5e
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-18T23:50:48Z
Merge remote-tracking branch 'upstream/master'
commit 990c4648a1427ca7c3c27453fe2a40cd5cac3734
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-19T17:18:54Z
Merge remote-tracking branch 'upstream/master'
commit ae4b5647e25d6e6915486c6ac4a42e887a53101c
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-19T17:44:16Z
FLINK-7603 Document how to take a savepoint on YARN
commit f82db156e6cabab9f43b7c3ec658b0ddc1a0637c
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-19T17:48:48Z
update doc
----
---
[GitHub] flink issue #4684: [FLINK-6703][savepoint/doc] Document how to take a savepo...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4684
Sorry, I realized I used the wrong jira ticket number. I'm closing this one, and the new PR is at https://github.com/apache/flink/pull/4721
---
[GitHub] flink pull request #4684: [FLINK-7603][savepoint/doc] Document how to take a...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4684#discussion_r140050554
--- Diff: docs/ops/cli.md ---
@@ -138,17 +138,30 @@ This allows the job to finish processing all inflight data.
[Savepoints]({{site.baseurl}}/ops/state/savepoints.html) are controlled via the command line client:
-#### Trigger a savepoint
+#### Trigger a Savepoint
{% highlight bash %}
-./bin/flink savepoint <jobID> [savepointDirectory]
+./bin/flink savepoint <jobId> [savepointDirectory]
{% endhighlight %}
-Returns the path of the created savepoint. You need this path to restore and dispose savepoints.
+This will trigger a savepoint for the job with ID `jobId`, and returns the path of the created savepoint. You need this path to restore and dispose savepoints.
-You can optionally specify a `savepointDirectory` when triggering the savepoint. If you don't specify one here, you need to configure a default savepoint directory for the Flink installation (see [Savepoints]({{site.baseurl}}/ops/state/savepoints.html#configuration)).
-##### Cancel with a savepoint
+Furthermore, you can optionally specify a target file system directory to store the savepoint in. The directory needs to be accessible by the JobManager.
--- End diff --
what do you by 'specifying the target path'? AFAIU, it has to be a directory, because the checkpoint dir name is a random hash.
The wordage of this part is borrowed from [the original doc](https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/cli.html#trigger-a-savepoint)
---
[GitHub] flink issue #4684: [FLINK-7603][savepoint/doc] Document how to take a savepo...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4684
cc @zentol
---
[GitHub] flink pull request #4684: [FLINK-6703][savepoint/doc] Document how to take a...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 closed the pull request at:
https://github.com/apache/flink/pull/4684
---
[GitHub] flink pull request #4684: [FLINK-7603][savepoint/doc] Document how to take a...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4684#discussion_r139929465
--- Diff: docs/ops/cli.md ---
@@ -138,17 +138,30 @@ This allows the job to finish processing all inflight data.
[Savepoints]({{site.baseurl}}/ops/state/savepoints.html) are controlled via the command line client:
-#### Trigger a savepoint
+#### Trigger a Savepoint
{% highlight bash %}
-./bin/flink savepoint <jobID> [savepointDirectory]
+./bin/flink savepoint <jobId> [savepointDirectory]
{% endhighlight %}
-Returns the path of the created savepoint. You need this path to restore and dispose savepoints.
+This will trigger a savepoint for the job with ID `jobId`, and returns the path of the created savepoint. You need this path to restore and dispose savepoints.
-You can optionally specify a `savepointDirectory` when triggering the savepoint. If you don't specify one here, you need to configure a default savepoint directory for the Flink installation (see [Savepoints]({{site.baseurl}}/ops/state/savepoints.html#configuration)).
-##### Cancel with a savepoint
+Furthermore, you can optionally specify a target file system directory to store the savepoint in. The directory needs to be accessible by the JobManager.
--- End diff --
Perhaps also mention the option to specify the target path?
---