[jira] [Commented] (JOHNZON-192) Switch johnzon-maven-plugin class generation from manual source writer to a more robust solution

["Jean-Louis Monteiro (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JOHNZON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17724797#comment-17724797 ] 

Jean-Louis Monteiro commented on JOHNZON-192:
---------------------------------------------

From a balance point of view, do we still want to merge this because the code is more maintainable and testable? Or do we think current situation is better?

 

Of course there are advantages for each of the approaches. I'm tempted to say having better maintainability and testing is good. Now our usage is really on the side of the project. So I'm happy either way.

> Switch johnzon-maven-plugin class generation from manual source writer to a more robust solution
> ------------------------------------------------------------------------------------------------
>
>                 Key: JOHNZON-192
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-192
>             Project: Johnzon
>          Issue Type: Improvement
>    Affects Versions: 1.1.10
>            Reporter: Simone Tripodi
>            Priority: Minor
>
> Currently, generated sources are obtained by writing strings to a writer; it works for current needs but is not really comfort to maintain.
> I am going to submit a PullRequest to improve that current situation by delegating the Java source code generation to https://github.com/square/javapoet, a more robust and strongly-typed solution provided by Square.
> Testing is also something that can be improved, in the Pull request I am proposing a (simple) syntax-tree comparison, rather than mere string comparison.
> Generated source code is still the same, even if with a slightly different format, but Mojo source is easier to maintain.
> I hope you'll like the PR :)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)