You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by rp...@apache.org on 2009/03/17 12:10:14 UTC
svn commit: r755190 - /httpd/httpd/trunk/modules/filters/mod_substitute.c
Author: rpluem
Date: Tue Mar 17 11:10:14 2009
New Revision: 755190
URL: http://svn.apache.org/viewvc?rev=755190&view=rev
Log:
* APR_BUCKET_NEXT is wrong here as we are already a doing a APR_BUCKET_NEXT in
the for loop and this causes us to jump *two* buckets forward. This can cause
us to jump over the Sentinel of the brigade and thus causes an endless loop.
Modified:
httpd/httpd/trunk/modules/filters/mod_substitute.c
Modified: httpd/httpd/trunk/modules/filters/mod_substitute.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_substitute.c?rev=755190&r1=755189&r2=755190&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/filters/mod_substitute.c (original)
+++ httpd/httpd/trunk/modules/filters/mod_substitute.c Tue Mar 17 11:10:14 2009
@@ -199,7 +199,6 @@
tmp_b = apr_bucket_transient_create(s1, strlen(s1),
f->r->connection->bucket_alloc);
APR_BUCKET_INSERT_BEFORE(b, tmp_b);
- tmp_b = APR_BUCKET_NEXT(b);
apr_bucket_delete(b);
b = tmp_b;
}
@@ -249,7 +248,6 @@
tmp_b = apr_bucket_transient_create(s1, strlen(s1),
f->r->connection->bucket_alloc);
APR_BUCKET_INSERT_BEFORE(b, tmp_b);
- tmp_b = APR_BUCKET_NEXT(b);
apr_bucket_delete(b);
b = tmp_b;
}