Re: [DISCUSS] NOTICE

[Stephan Ewen <se...@apache.org>]

Hi!

I general, adopting code from other Apache projects is okay and needs no
special notice (per the Apache License 2.0). It is good style to add
comments above the copied code, definitely.

As far as I understand it, you add an entry to the NOTICE file when you
find other NOTICE files, or when the license of the copied code requires
that.
In the lodash JavaScript file is a comment that I interpreted that this
needs to be carried into the NOTICE file.

Does that answer the question?

Stephan


On Wed, May 31, 2017 at 3:13 PM, Greg Hogan <co...@greghogan.com> wrote:

> In several locations we have copied code from external projects, for
> example
> flink-scala-shell/src/main/java/org/apache/flink/api/java/JarHelper.java
> links to the file from org.apache.xmlbeans/xmlbeans/2.4.0. We also have
> copied from Apache's Calcite, Spark, and Hadoop.
>
> None of these projects are referenced in Flink's NOTICE or LICENSE. Is this
> unnecessary because all Apache project code is is copyright the ASF (or
> public domain)?
>
> Also, lodash is cited in Flink's NOTICE but there is no lodash NOTICE at
> https://github.com/lodash/lodash. We do properly cite the project in the
> MIT License section of Flink's LICENSE.
>
> Greg
>

Re: [DISCUSS] NOTICE

[Nico Kruber <ni...@data-artisans.com>]

I actually ran into the same thing again, when I needed to copy a file from 
Netty's tests (an abstract test base class) and was not quite sure what 4d) 
under the ASL 2.0 meant:

<quote>
4. Redistribution. You may reproduce and distribute copies of the Work or 
Derivative Works thereof in any medium, with or without modifications, and in 
Source or Object form, provided that You meet the following conditions:

[...]
d.    If the Work includes a "NOTICE" text file as part of its distribution, 
then any Derivative Works that You distribute must include a readable copy of 
the attribution notices contained within such NOTICE file, excluding those 
notices that do not pertain to any part of the Derivative Works, in at least 
one of the following places: within a NOTICE text file distributed as part of 
the Derivative Works; within the Source form or documentation, if provided 
along with the Derivative Works; or, within a display generated by the 
Derivative Works, if and wherever such third-party notices normally appear. 
The contents of the NOTICE file are for informational purposes only and do not 
modify the License. You may add Your own attribution notices within Derivative 
Works that You distribute, alongside or as an addendum to the NOTICE text from 
the Work, provided that such additional attribution notices cannot be 
construed as modifying the License.

    You may add Your own copyright statement to Your modifications and may 
provide additional or different license terms and conditions for use, 
reproduction, or distribution of Your modifications, or for any such Derivative 
Works as a whole, provided Your use, reproduction, and distribution of the 
Work otherwise complies with the conditions stated in this License.
</quote>

The question it boils down to is: What are "attribution notices contained 
within such NOTICE file"? Netty in particular is not copyrighted by the ASF and 
their notice file starts with 


<quote>
                            The Netty Project
                            =================

Please visit the Netty web site for more information:

  * http://netty.io/

Copyright 2011 The Netty Project
</quote>

followed by attribution notices to other projects not relevant to my PR.

Do we need to bubble this copyright notice (or a short form attributing 
Netty's copyright) up into our NOTICE file as well (although the ASL itself 
does not require attribution)?

To be clear: I kept the file header and marked it as changed as required - this 
is only about the NOTICE file!


Nico

On Wednesday, 12 July 2017 16:34:19 CEST Stephan Ewen wrote:
> Hi!
> 
> I general, adopting code from other Apache projects is okay and needs no
> special notice (per the Apache License 2.0). It is good style to add
> comments above the copied code, definitely.
> 
> As far as I understand it, you add an entry to the NOTICE file when you
> find other NOTICE files, or when the license of the copied code requires
> that.
> In the lodash JavaScript file is a comment that I interpreted that this
> needs to be carried into the NOTICE file.
> 
> Does that answer the question?
> 
> Stephan
> 
> On Wed, May 31, 2017 at 3:13 PM, Greg Hogan <co...@greghogan.com> wrote:
> > In several locations we have copied code from external projects, for
> > example
> > flink-scala-shell/src/main/java/org/apache/flink/api/java/JarHelper.java
> > links to the file from org.apache.xmlbeans/xmlbeans/2.4.0. We also have
> > copied from Apache's Calcite, Spark, and Hadoop.
> > 
> > None of these projects are referenced in Flink's NOTICE or LICENSE. Is
> > this
> > unnecessary because all Apache project code is is copyright the ASF (or
> > public domain)?
> > 
> > Also, lodash is cited in Flink's NOTICE but there is no lodash NOTICE at
> > https://github.com/lodash/lodash. We do properly cite the project in the
> > MIT License section of Flink's LICENSE.
> > 
> > Greg