[GitHub] [arrow-datafusion] thinkharderdev commented on a diff in pull request #2578: Extract Listing URI logic into ListingTableUri structure

[GitBox <gi...@apache.org>]

thinkharderdev commented on code in PR #2578:
URL: https://github.com/apache/arrow-datafusion/pull/2578#discussion_r877046195


##########
ballista/rust/core/src/serde/physical_plan/mod.rs:
##########
@@ -1029,14 +1029,10 @@ fn decode_scan_config(
         .map(|f| f.try_into())
         .collect::<Result<Vec<_>, _>>()?;
 
-    let object_store = if let Some(file) = file_groups.get(0).and_then(|h| h.get(0)) {
-        runtime.object_store(file.file_meta.path())?.0
-    } else {
-        Arc::new(LocalFileSystem {})
-    };
+    // TODO: This will not roundtrip object storage correctly as it loses the scheme

Review Comment:
   Yeah, I think originally I had added a `fn scheme(&self) -> String` method to `ObjectStore` and then we can add that into the serialized `FileScanExecConf`. 
   
   I got rid of it before merging because I thought using the scheme from the file URI would be simpler, but I guess we need to bring it back. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org