[GitHub] [superset] suddjian commented on a change in pull request #15647: refactor: icon to icons for IconButton and Header component

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15647:
URL: https://github.com/apache/superset/pull/15647#discussion_r669120547



##########
File path: superset-frontend/src/components/IconButton/index.tsx
##########
@@ -41,6 +41,15 @@ const StyledImage = styled.div`
   height: ${({ theme }) => theme.gridUnit * 18}px;
   margin: ${({ theme }) => theme.gridUnit * 3}px 0;
 
+  .default-db-icon {
+    font-size: ${({ theme }) => theme.gridUnit * 9}px;

Review comment:
       Font sizes shouldn't be set using grid units. There is `theme.typography.sizes` for that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org