You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2019/05/19 00:49:16 UTC
[pulsar] 01/26: [pulsar-broker] add producer/consumer id in
error-logging (#3961)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 6a8d8389d8d37ca5bdc9fa379220206e431904e7
Author: Rajan Dhabalia <rd...@apache.org>
AuthorDate: Sun Apr 7 22:23:51 2019 -0700
[pulsar-broker] add producer/consumer id in error-logging (#3961)
### Motivation
Log Producer/Consumer Id when broker logs "Producer/consumer is already connected" to help in debugging when client is keep failing to create producer and broker is keep logging the same error.
---
.../java/org/apache/pulsar/broker/service/ServerCnx.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
index e5bbf51..046567f 100644
--- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
+++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
@@ -567,8 +567,8 @@ public class ServerCnx extends PulsarHandler {
if (existingConsumerFuture != null) {
if (existingConsumerFuture.isDone() && !existingConsumerFuture.isCompletedExceptionally()) {
Consumer consumer = existingConsumerFuture.getNow(null);
- log.info("[{}] Consumer with the same id is already created: {}", remoteAddress,
- consumer);
+ log.info("[{}] Consumer with the same id {} is already created: {}", remoteAddress,
+ consumerId, consumer);
ctx.writeAndFlush(Commands.newSuccess(requestId));
return null;
} else {
@@ -577,8 +577,8 @@ public class ServerCnx extends PulsarHandler {
// client timeout is lower the broker timeouts. We need to wait until the previous
// consumer
// creation request either complete or fails.
- log.warn("[{}][{}][{}] Consumer is already present on the connection", remoteAddress,
- topicName, subscriptionName);
+ log.warn("[{}][{}][{}] Consumer with id {} is already present on the connection", remoteAddress,
+ topicName, subscriptionName, consumerId);
ServerError error = !existingConsumerFuture.isDone() ? ServerError.ServiceNotReady
: getErrorCode(existingConsumerFuture);
ctx.writeAndFlush(Commands.newError(requestId, error,
@@ -755,8 +755,8 @@ public class ServerCnx extends PulsarHandler {
if (existingProducerFuture != null) {
if (existingProducerFuture.isDone() && !existingProducerFuture.isCompletedExceptionally()) {
Producer producer = existingProducerFuture.getNow(null);
- log.info("[{}] Producer with the same id is already created: {}", remoteAddress,
- producer);
+ log.info("[{}] Producer with the same id {} is already created: {}", remoteAddress,
+ producerId, producer);
ctx.writeAndFlush(Commands.newProducerSuccess(requestId, producer.getProducerName(),
producer.getSchemaVersion()));
return null;
@@ -770,8 +770,8 @@ public class ServerCnx extends PulsarHandler {
// either complete or fails.
ServerError error = !existingProducerFuture.isDone() ? ServerError.ServiceNotReady
: getErrorCode(existingProducerFuture);
- log.warn("[{}][{}] Producer is already present on the connection", remoteAddress,
- topicName);
+ log.warn("[{}][{}] Producer with id {} is already present on the connection", remoteAddress,
+ producerId, topicName);
ctx.writeAndFlush(Commands.newError(requestId, error,
"Producer is already present on the connection"));
return null;