You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2023/01/03 11:31:20 UTC
[GitHub] [qpid-proton] DreamPearl opened a new pull request, #385: PROTON-2657: [cpp] Accessors for user data on endpoints and deliveries
DreamPearl opened a new pull request, #385:
URL: https://github.com/apache/qpid-proton/pull/385
[PROTON-2657](https://issues.apache.org/jira/browse/PROTON-2657)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl commented on pull request #385: PROTON-2657: [cpp] Accessors for user data on endpoints and deliveries
Posted by GitBox <gi...@apache.org>.
DreamPearl commented on PR #385:
URL: https://github.com/apache/qpid-proton/pull/385#issuecomment-1380856413
PR merged as https://github.com/apache/qpid-proton/commit/51583a51652074586d4672b116224ec1b48de387.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] DreamPearl closed pull request #385: PROTON-2657: [cpp] Accessors for user data on endpoints and deliveries
Posted by GitBox <gi...@apache.org>.
DreamPearl closed pull request #385: PROTON-2657: [cpp] Accessors for user data on endpoints and deliveries
URL: https://github.com/apache/qpid-proton/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] PROTON-2657: [cpp] Accessors for user data on endpoints and deliveries [qpid-proton]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #385:
URL: https://github.com/apache/qpid-proton/pull/385#issuecomment-4173632062
## [Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/385?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `92.59259%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 69.71%. Comparing base ([`06956b1`](https://app.codecov.io/gh/apache/qpid-proton/commit/06956b155658ff3829bfe920f386caf5c7941c46?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f0b681a`](https://app.codecov.io/gh/apache/qpid-proton/commit/f0b681adf58f8fa8387a9eaf57ed966e9828f9d8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 252 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/qpid-proton/pull/385?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [cpp/examples/broker.cpp](https://app.codecov.io/gh/apache/qpid-proton/pull/385?src=pr&el=tree&filepath=cpp%2Fexamples%2Fbroker.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL2V4YW1wbGVzL2Jyb2tlci5jcHA=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/qpid-proton/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #385 +/- ##
===========================================
- Coverage 88.34% 69.71% -18.64%
===========================================
Files 47 372 +325
Lines 2394 71727 +69333
===========================================
+ Hits 2115 50003 +47888
- Misses 279 21724 +21445
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/385?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org