[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41083: [SPARK-43399][CORE] Add config to control threshold of unregister map ouput when fetch failed

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #41083:
URL: https://github.com/apache/spark/pull/41083#discussion_r1186909561


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2516,4 +2516,13 @@ package object config {
       .version("3.5.0")
       .booleanConf
       .createWithDefault(false)
+
+  private[spark] val UNREGISTER_OUTPUT_THRESHOLD_ON_FETCH_FAILURE =
+    ConfigBuilder("spark.files.fetchFailure.unRegisterOutputThreshold")

Review Comment:
   If you want to use `spark.files.fetchFailure.` namespace, could you move this after the existing config?
   
   https://github.com/apache/spark/blob/1e090a57f0c6aa342c032130bbf86f8a152b9fee/core/src/main/scala/org/apache/spark/internal/config/package.scala#L942-L949



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org