[GitHub] [logging-log4j2] davemessink commented on issue #1273: ReusableMessages not getting released when using entry/exit logging

["davemessink (via GitHub)" <gi...@apache.org>]

davemessink commented on issue #1273:
URL: https://github.com/apache/logging-log4j2/issues/1273#issuecomment-1425018910

   I'm not sure I'm comfortable moving the release/recycle logic into memento(). Is that the suggestion here? Other uses of memento() are to populate the ring buffer event builder and the MutibleLogEvent. The release() call is currently outside of those blocks (it's currently called by the AbstractLogger in a try/finally block).
   
   I see that a lot of this logic is changing in #1193, what's the suggestion on timing of my PR and that one. Should I wait and address this after that PR is merged? Or get my PR merged quickly?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org