[GitHub] [camel-k] astefanutti commented on issue #1590: Restore flow type as object?

[GitBox <gi...@apache.org>]

astefanutti commented on issue #1590:
URL: https://github.com/apache/camel-k/issues/1590#issuecomment-653479899


   Sorry, I failed to proactively warn you about this, but knew it would soon come back to haunt me :)
   
   The previous `type Flow map[string]interface{}` was getting into the way of enabling CRD generation, and also leads to the question of schema validation.
   
   I initially used `type Flow json.RawMessage` in 45bc5e9dd0b3386ed999d58ce58b555c8cc834bd, and I fail to remember why I ultimately decided to go for `type Flow string`. I think it was just more convenient to use, without more context. While it worked, you're right it's not transparent from a schema standpoint.
   
   I think using `json.RawMessage` or `runtime.RawExtension` should be less disruptive and enable to get back to what we had before.
   
   More context can be found in https://github.com/kubernetes-sigs/controller-tools/issues/294.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org