You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stdcxx.apache.org by Martin Sebor <se...@roguewave.com> on 2008/06/30 21:42:09 UTC
Re: svn commit: r672048 - /stdcxx/branches/4.3.x/tests/utilities/
vitek@apache.org wrote:
> Author: vitek
> Date: Thu Jun 26 15:48:21 2008
> New Revision: 672048
>
> URL: http://svn.apache.org/viewvc?rev=672048&view=rev
> Log:
> 2008-06-27 Travis Vitek <vi...@roguewave.com>
>
> * tests/utilities/20.forward.cpp [_RWSTD_NO_EXT_CXX_0X]: Add
> guard to get test to compile and run when extension is not
> explicitly enabled. Include rw/_defs.h explicitly in case
> rw_driver.h does not.
Every stdcxx header should always end up #including <rw/_defs.h>
so that no code outside the library needs to (as always, there
are unavoidable exceptions). <rw_driver.h> includes the header
via <rw_testdefs.h> which in turn should be #included by every
test driver header. Are there any circumstances when this
doesn't happen?
Martin
Re: svn commit: r672048 - /stdcxx/branches/4.3.x/tests/utilities/
Posted by Martin Sebor <se...@roguewave.com>.
Travis Vitek wrote:
>
>
> Martin Sebor wrote:
>> vitek@apache.org wrote:
>>> Author: vitek
>>> Date: Thu Jun 26 15:48:21 2008
>>> New Revision: 672048
>>>
>>> URL: http://svn.apache.org/viewvc?rev=672048&view=rev
>>> Log:
>>> 2008-06-27 Travis Vitek <vi...@roguewave.com>
>>>
>>> * tests/utilities/20.forward.cpp [_RWSTD_NO_EXT_CXX_0X]: Add
>>> guard to get test to compile and run when extension is not
>>> explicitly enabled. Include rw/_defs.h explicitly in case
>>> rw_driver.h does not.
>> Every stdcxx header should always end up #including <rw/_defs.h>
>> so that no code outside the library needs to (as always, there
>> are unavoidable exceptions). <rw_driver.h> includes the header
>> via <rw_testdefs.h> which in turn should be #included by every
>> test driver header.
>
> Yes, I know.
>
>> Are there any circumstances when this doesn't happen?
>
> No. My comment is misleading. I'm simply applying the undocumented style
> for #include directives in stdcxx [http://tinyurl.com/6abxfz], which is
> quoted below...
This applies to library headers only (modulo exceptions, the
rest of the project doesn't #include any private headers as
a rule).
>
> >
> >> 2. include directives are in alphabetical order, with
> >> rw/_defs.h being last (it still ends up getting included
> >> first, indirectly, by the first header); the exception
> >> here is when a stdcxx config macro needs to be tested
> >> before the first #include directive
> >
>
>> Martin
>>
>>
RE: svn commit: r672048 - /stdcxx/branches/4.3.x/tests/utilities/
Posted by Travis Vitek <Tr...@roguewave.com>.
Martin Sebor wrote:
>
>vitek@apache.org wrote:
>> Author: vitek
>> Date: Thu Jun 26 15:48:21 2008
>> New Revision: 672048
>>
>> URL: http://svn.apache.org/viewvc?rev=672048&view=rev
>> Log:
>> 2008-06-27 Travis Vitek <vi...@roguewave.com>
>>
>> * tests/utilities/20.forward.cpp [_RWSTD_NO_EXT_CXX_0X]: Add
>> guard to get test to compile and run when extension is not
>> explicitly enabled. Include rw/_defs.h explicitly in case
>> rw_driver.h does not.
>
>Every stdcxx header should always end up #including <rw/_defs.h>
>so that no code outside the library needs to (as always, there
>are unavoidable exceptions). <rw_driver.h> includes the header
>via <rw_testdefs.h> which in turn should be #included by every
>test driver header.
Yes, I know.
>
> Are there any circumstances when this doesn't happen?
No. My comment is misleading. I'm simply applying the undocumented style
for #include directives in stdcxx [http://tinyurl.com/6abxfz], which is
quoted below...
>
>> 2. include directives are in alphabetical order, with
>> rw/_defs.h being last (it still ends up getting included
>> first, indirectly, by the first header); the exception
>> here is when a stdcxx config macro needs to be tested
>> before the first #include directive
>
>Martin
>
>