You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Hadrian Zbarcea (JIRA)" <ji...@apache.org> on 2011/08/24 23:16:29 UTC

[jira] [Created] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
-----------------------------------------------------------------------------------

                 Key: CAMEL-4376
                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
             Project: Camel
          Issue Type: Improvement
          Components: camel-core
    Affects Versions: 2.8.0
            Reporter: Hadrian Zbarcea
            Assignee: Hadrian Zbarcea
             Fix For: 2.8.1, 2.9.0


There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).

    protected DefaultEndpoint(String, CamelContext);
    protected DefaultEndpoint(String);
possibly
    protected DefaultEndpoint();

There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Work started] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on CAMEL-4376 started by Hadrian Zbarcea.

> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091030#comment-13091030 ] 

Hadrian Zbarcea commented on CAMEL-4376:
----------------------------------------

Yes, shouldn't change in 2.8.1.

The issue with <beean class="*Endpoint" /> is that it's not that useful to create an endpoint that way imho. Not sure why we would allow that. Will leave it in for now.

> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Claus Ibsen (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-4376.
--------------------------------

    Resolution: Fixed
    
> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090762#comment-13090762 ] 

Claus Ibsen commented on CAMEL-4376:
------------------------------------

The default ctr should definitely be there as people use that to create endpoints in eg spring xml file

For example
<bean id="myEndpoint" class="org.apache.camel....SedaEndpoint">
   < set some options here >
</bean>



> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.8.1, 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090763#comment-13090763 ] 

Claus Ibsen commented on CAMEL-4376:
------------------------------------

And I would not change anything in a patch release such as camel 2.8.1. If we are to do anything then do that only in 2.9 release.

> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.8.1, 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CAMEL-4376) Deprecate DefaultEndpoint constructors that create partially constructed endpoints

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-4376:
-----------------------------------

    Fix Version/s:     (was: 2.8.1)

> Deprecate DefaultEndpoint constructors that create partially constructed endpoints 
> -----------------------------------------------------------------------------------
>
>                 Key: CAMEL-4376
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4376
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.8.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.9.0
>
>
> There are 2 DefaultEndpoint constructors that are not necessary, are not really used (and as the doc says they should not be used anyway) that I intend to remove. One issue is that during endpoint construction because the component and context are set later services from the context such as type converters are not yet available which may lead to errors (or unnecessarily complicated code).
>     protected DefaultEndpoint(String, CamelContext);
>     protected DefaultEndpoint(String);
> possibly
>     protected DefaultEndpoint();
> There are also a number of components defining constructors that just mimic those that are not necessary and not used either. Those can be removed now. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira