You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/11 20:21:34 UTC

[GitHub] [fineract] vorburger commented on a change in pull request #1022: FINERACT-822 enable UnnecessaryDefaultInEnumSwitch error

vorburger commented on a change in pull request #1022:
URL: https://github.com/apache/fineract/pull/1022#discussion_r439049336



##########
File path: fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java
##########
@@ -88,10 +88,8 @@ public void generateClientSchedule() {
                                 next = start.plusDays((int) (long) adhoc.getReportRunEvery());
                                 run = Days.daysBetween(start, end).getDays() >= adhoc.getReportRunEvery();
                                 break;
-                            default:
-                                throw new IllegalStateException();
                         }
-
+                        throw new IllegalStateException();

Review comment:
       wait... wat ??  By doing this, it will ALWAYS throw, no? This will completely break. @awasum please help..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org