You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/09 12:50:00 UTC

[GitHub] [dubbo] zrlw opened a new pull request #8755: close client immediately when destroy unused invoker

zrlw opened a new pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755


   ## What is the purpose of the change
   #8752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] YsoulM edited a comment on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
YsoulM edited a comment on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-969902129


   这个修复应该存在一个不太严重的问题，没有考虑到2.7.*升级到3.*的情况。
   出现问题的大体情况如下：
   如果consumer是2.7.4，provider先升级到3.0.3+，在provider发布的时候，consumer的健康检查还会异常。发布完成之后就没了。
   
   即使consumer也升级到了3.0.3+，provider发布期间，consumer也会出现异常，但是不是100%复现，日常日志如下：
   ```
   [DUBBO] Fail to connect to HeaderExchangeClient [channel=org.apache.dubbo.remoting.transport.netty4.NettyClient [0.0.0.0/0.0.0.0:52452 -> null]], dubbo version: 3.0.3, current host: 10.104.64.165
   org.apache.dubbo.remoting.RemotingException: client(url: dubbo://10.104.67.23:20880/cn.*.api.remoteservice.RemoteGeoService?anyhost=true&application=geo-server&check=false&cluster=failfast&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&heartbeat=60000&interface=cn.*.api.remoteservice.RemoteGeoService&isPerfTestSupportted=true&metadata-type=remote&methods=findGeoInfoByPoint,findGeoInfoByGeoHash&release=3.0.3&retries=0&serverApplicationName=geo-server&service-name-mapping=true&side=provider&threadpool=cached&threads=500&timeout=3000) failed to connect to server null client-side timeout 3000ms (elapsed: 3002ms) from netty client 10.104.64.165 using dubbo version 3.0.3
     at org.apache.dubbo.remoting.transport.netty4.NettyClient.doConnect(NettyClient.java:175)
     at org.apache.dubbo.remoting.transport.AbstractClient.connect(AbstractClient.java:202)
     at org.apache.dubbo.remoting.transport.AbstractClient.reconnect(AbstractClient.java:258)
     at org.apache.dubbo.remoting.exchange.support.header.HeaderExchangeClient.reconnect(HeaderExchangeClient.java:166)
     at org.apache.dubbo.remoting.exchange.support.header.ReconnectTimerTask.doTask(ReconnectTimerTask.java:49)
     at org.apache.dubbo.remoting.exchange.support.header.AbstractTimerTask.run(AbstractTimerTask.java:87)
     at org.apache.dubbo.common.timer.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:648)
     at org.apache.dubbo.common.timer.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:727)
     at org.apache.dubbo.common.timer.HashedWheelTimer$Worker.run(HashedWheelTimer.java:449)
     at java.lang.Thread.run(Thread.java:748)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] changfubai commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
changfubai commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916566047


   大佬太强了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] YsoulM commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
YsoulM commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916590923


   感谢大佬！！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] leimbag commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
leimbag commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-1019929715


   3.0.5版本依然有相同的问题，
   `ReconnectTimerTask.doTask:51 -  [DUBBO] Fail to connect to HeaderExchangeClient [channel=org.apache.dubbo.remoting.transport.netty4.NettyClient [/172.16.204.201:58880 -> /172.16.204.201:29811]], dubbo version: 3.0.5, current host: 172.16.204.201`
   
   生产者下线后，消费者无限重连生产者服务，每60秒重连一次


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8755: close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916115282


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8755](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (309a8ab) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1b100f84cb51a590c865e2d28d159b4d4c203409?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b100f8) will **increase** coverage by `0.01%`.
   > The diff coverage is `25.00%`.
   
   > :exclamation: Current head 309a8ab differs from pull request most recent head bd76d84. Consider uploading reports for the commit bd76d84 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8755/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8755      +/-   ##
   ============================================
   + Coverage     63.70%   63.71%   +0.01%     
   - Complexity      312      313       +1     
   ============================================
     Files          1145     1147       +2     
     Lines         48188    48202      +14     
     Branches       7255     7256       +1     
   ============================================
   + Hits          30699    30714      +15     
   + Misses        14123    14120       -3     
   - Partials       3366     3368       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `45.98% <0.00%> (ø)` | |
   | [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `49.66% <0.00%> (ø)` | |
   | [...apache/dubbo/remoting/exchange/ExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9FeGNoYW5nZUNsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...pi/src/main/java/org/apache/dubbo/rpc/Invoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZva2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...c/protocol/dubbo/ReferenceCountExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL1JlZmVyZW5jZUNvdW50RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `65.00% <28.57%> (-2.86%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `67.60% <42.85%> (-3.17%)` | :arrow_down: |
   | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `65.21% <0.00%> (-4.35%)` | :arrow_down: |
   | [.../client/metadata/ServiceInstanceMetadataUtils.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvU2VydmljZUluc3RhbmNlTWV0YWRhdGFVdGlscy5qYXZh) | `84.61% <0.00%> (-2.89%)` | :arrow_down: |
   | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyQ2xpZW50LmphdmE=) | `74.38% <0.00%> (-0.99%)` | :arrow_down: |
   | [...ava/org/apache/dubbo/common/utils/ConfigUtils.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29uZmlnVXRpbHMuamF2YQ==) | `69.51% <0.00%> (-0.61%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b100f8...bd76d84](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] YsoulM removed a comment on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
YsoulM removed a comment on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916590923


   感谢大佬！！


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916115282


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8755](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be0b14f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1b100f84cb51a590c865e2d28d159b4d4c203409?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b100f8) will **decrease** coverage by `0.10%`.
   > The diff coverage is `40.90%`.
   
   > :exclamation: Current head be0b14f differs from pull request most recent head bd76d84. Consider uploading reports for the commit bd76d84 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8755/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8755      +/-   ##
   ============================================
   - Coverage     63.70%   63.60%   -0.11%     
   - Complexity      312      313       +1     
   ============================================
     Files          1145     1147       +2     
     Lines         48188    48202      +14     
     Branches       7255     7256       +1     
   ============================================
   - Hits          30699    30659      -40     
   - Misses        14123    14167      +44     
   - Partials       3366     3376      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/dubbo/remoting/exchange/ExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9FeGNoYW5nZUNsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...c/protocol/dubbo/ReferenceCountExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL1JlZmVyZW5jZUNvdW50RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `65.00% <28.57%> (-2.86%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `67.60% <42.85%> (-3.17%)` | :arrow_down: |
   | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `45.98% <50.00%> (ø)` | |
   | [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `49.66% <50.00%> (ø)` | |
   | [...pi/src/main/java/org/apache/dubbo/rpc/Invoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZva2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-20.69%)` | :arrow_down: |
   | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: |
   | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: |
   | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0.00%> (-10.87%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b100f8...bd76d84](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-916115282


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8755](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be0b14f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1b100f84cb51a590c865e2d28d159b4d4c203409?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b100f8) will **decrease** coverage by `0.18%`.
   > The diff coverage is `40.90%`.
   
   > :exclamation: Current head be0b14f differs from pull request most recent head bd76d84. Consider uploading reports for the commit bd76d84 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8755/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8755      +/-   ##
   ============================================
   - Coverage     63.70%   63.52%   -0.19%     
     Complexity      312      312              
   ============================================
     Files          1145     1147       +2     
     Lines         48188    48156      -32     
     Branches       7255     7221      -34     
   ============================================
   - Hits          30699    30590     -109     
   - Misses        14123    14179      +56     
   - Partials       3366     3387      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/dubbo/remoting/exchange/ExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9FeGNoYW5nZUNsaWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...c/protocol/dubbo/ReferenceCountExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL1JlZmVyZW5jZUNvdW50RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `65.00% <28.57%> (-2.86%)` | :arrow_down: |
   | [.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvSW52b2tlci5qYXZh) | `67.60% <42.85%> (-3.17%)` | :arrow_down: |
   | [...stry/client/ServiceDiscoveryRegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvU2VydmljZURpc2NvdmVyeVJlZ2lzdHJ5RGlyZWN0b3J5LmphdmE=) | `45.98% <50.00%> (ø)` | |
   | [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeURpcmVjdG9yeS5qYXZh) | `49.66% <50.00%> (ø)` | |
   | [...pi/src/main/java/org/apache/dubbo/rpc/Invoker.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZva2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-20.69%)` | :arrow_down: |
   | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: |
   | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75.00% <0.00%> (-12.50%)` | :arrow_down: |
   | [...ubbo/registry/client/AbstractServiceDiscovery.java](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvQWJzdHJhY3RTZXJ2aWNlRGlzY292ZXJ5LmphdmE=) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
   | ... and [54 more](https://codecov.io/gh/apache/dubbo/pull/8755/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1b100f8...bd76d84](https://codecov.io/gh/apache/dubbo/pull/8755?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] YsoulM commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
YsoulM commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-969902129


   这个修复应该存在一个不太严重的问题，没有考虑到2.7.*升级到3.*的情况。
   出现问题的大体情况如下：
   如果consumer是2.7.4，provider先升级到3.0.3+，在provider发布的时候，consumer的健康检查还会异常。发布完成之后就没了。
   
   
   即使consumer也升级到了2.7.4也会出现异常，但是不是100%复现：
   ```
   [DUBBO] Fail to connect to HeaderExchangeClient [channel=org.apache.dubbo.remoting.transport.netty4.NettyClient [0.0.0.0/0.0.0.0:52452 -> null]], dubbo version: 3.0.3, current host: 10.104.64.165
   org.apache.dubbo.remoting.RemotingException: client(url: dubbo://10.104.67.23:20880/cn.*.api.remoteservice.RemoteGeoService?anyhost=true&application=geo-server&check=false&cluster=failfast&codec=dubbo&deprecated=false&dubbo=2.0.2&dynamic=true&generic=false&heartbeat=60000&interface=cn.*.api.remoteservice.RemoteGeoService&isPerfTestSupportted=true&metadata-type=remote&methods=findGeoInfoByPoint,findGeoInfoByGeoHash&release=3.0.3&retries=0&serverApplicationName=geo-server&service-name-mapping=true&side=provider&threadpool=cached&threads=500&timeout=3000) failed to connect to server null client-side timeout 3000ms (elapsed: 3002ms) from netty client 10.104.64.165 using dubbo version 3.0.3
     at org.apache.dubbo.remoting.transport.netty4.NettyClient.doConnect(NettyClient.java:175)
     at org.apache.dubbo.remoting.transport.AbstractClient.connect(AbstractClient.java:202)
     at org.apache.dubbo.remoting.transport.AbstractClient.reconnect(AbstractClient.java:258)
     at org.apache.dubbo.remoting.exchange.support.header.HeaderExchangeClient.reconnect(HeaderExchangeClient.java:166)
     at org.apache.dubbo.remoting.exchange.support.header.ReconnectTimerTask.doTask(ReconnectTimerTask.java:49)
     at org.apache.dubbo.remoting.exchange.support.header.AbstractTimerTask.run(AbstractTimerTask.java:87)
     at org.apache.dubbo.common.timer.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:648)
     at org.apache.dubbo.common.timer.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:727)
     at org.apache.dubbo.common.timer.HashedWheelTimer$Worker.run(HashedWheelTimer.java:449)
     at java.lang.Thread.run(Thread.java:748)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] YsoulM commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
YsoulM commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-969902800


   @zrlw @AlbumenJ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-970043897


   这个修复修改的只是client端，不升级client应该是没有效果。
   另外修复只是停止无休止的重连，client的reconnect任务和provider停止之间存在时间差，期间出现的重连请求应该都会抛出连接异常。
   @YsoulM 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw edited a comment on pull request #8755: [3.0] close client immediately when destroy unused invoker

Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #8755:
URL: https://github.com/apache/dubbo/pull/8755#issuecomment-970043897


   这个修复修改的只是client端，不升级client应该是没有效果。
   另外修复只是停止无休止的重连，client的reconnect任务和client感知provider停止之间存在时间差，期间出现的重连请求应该都会抛出连接异常。
   @YsoulM 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org