You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by YehEmily <gi...@git.apache.org> on 2017/07/18 21:34:17 UTC
[GitHub] geode pull request #642: GEODE-3031: Extracting startLocator and startServer...
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/642
GEODE-3031: Extracting startLocator and startServer from LauncherLifecycleCommands
[See the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3031?jql=project%20%3D%20GEODE%20AND%20text%20~%20%22launcherlifecyclecommands%22)
`LauncherLifecycleCommands.java` was a huge class that contained commands for starting a server (`startServer`) and for starting a locator (`startLocator`). As a result, these gfsh commands were extracted. Then, the other methods associated with these two gfsh commands were refactored and moved to other classes.
**Testing Progress:** Precheckin running
- [x] JIRA ticket associated with this PR is referenced in the commit message
- [x] PR has been rebased against the latest commit within the target branch
- [x] Initial contribution is a single, squashed commit
- [x] `gradlew build` runs cleanly
- [x] Wrote/updated unit tests to verify changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3031
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #642
----
commit e37930172e46d36433ba2c479d04ed69a7a16902
Author: YehEmily <em...@gmail.com>
Date: 2017-07-17T21:35:50Z
GEODE-3031: Extracting startLocator and startServer from LauncherLifecycleCommands, removing the entire LauncherLifecycleCommands class, and moving tests from LauncherLifecycleCommandsTest to GfshCommandTest, StartServerCommands, and StartLocatorCommands
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #642: GEODE-3031: Extracting startLocator and startServer...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---