You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/10/26 06:35:56 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #11554: Add worker category dimension

clintropolis commented on a change in pull request #11554:
URL: https://github.com/apache/druid/pull/11554#discussion_r736187832



##########
File path: extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
##########
@@ -63,11 +63,11 @@
   "task/pending/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
   "task/waiting/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
 
-  "taskSlot/total/count" : { "dimensions" : [], "type" : "gauge" },
-  "taskSlot/idle/count" : { "dimensions" : [], "type" : "gauge" },
-  "taskSlot/busy/count" : { "dimensions" : [], "type" : "gauge" },
-  "taskSlot/lazy/count" : { "dimensions" : [], "type" : "gauge" },
-  "taskSlot/blacklisted/count" : { "dimensions" : [], "type" : "gauge" },
+  "taskSlot/total/count" : { "dimensions" : ["category"], "type" : "gauge" },

Review comment:
       hmm, it looks like other emitters have files like this too:
   
   * prometheus-emitter: https://github.com/apache/druid/blob/master/extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json
   * opentsdb-emitter: https://github.com/apache/druid/blob/master/extensions-contrib/opentsdb-emitter/src/main/resources/defaultMetrics.json
   * dropwizard-emitter: https://github.com/apache/druid/blob/master/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
   * graphite-emitter: https://github.com/apache/druid/blob/master/extensions-contrib/graphite-emitter/src/main/resources/defaultWhiteListMap.json
   * ambari-emitter: https://github.com/apache/druid/blob/master/extensions-contrib/ambari-metrics-emitter/src/main/resources/defaultWhiteListMap.json
   
   should they be updated as well after this change? I didn't look _super_ closely at their contents, and i'm not sure how consistent they actually are with each other since I'm not sure they are currently emitting these metrics at all... but this seemed worth discussing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org