You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/05 15:16:25 UTC
[GitHub] [airflow] potiuk opened a new pull request #7368: [AIRFLOW-6736]
Fix the repo/branch that is used in PRs for git sync
potiuk opened a new pull request #7368: [AIRFLOW-6736] Fix the repo/branch that is used in PRs for git sync
URL: https://github.com/apache/airflow/pull/7368
Kubernetes Git test uses always apache/airflow:master as source of files
This made it impossible to test how the Kubernetes GitSync test will behave
when merged. The git sync should always be done with the original repo/branch
or from the TRAVIS_BRANCH if this is a push build
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7368: [AIRFLOW-6736] Fix the
repo/branch that is used in PRs for git sync
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7368: [AIRFLOW-6736] Fix the repo/branch that is used in PRs for git sync
URL: https://github.com/apache/airflow/pull/7368#issuecomment-582457539
This fixes one of the causes of the master drama we had last weekend. With this change the Kubernetes tests with GitSync should be always executed against the original PR and not master of airflow repo - which makes it test the right thing + it won't fail after merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7368: [AIRFLOW-6736] Fix the
repo/branch that is used in PRs for git sync
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7368: [AIRFLOW-6736] Fix the repo/branch that is used in PRs for git sync
URL: https://github.com/apache/airflow/pull/7368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services