[jira] [Commented] (YUNIKORN-2335) Use go standard library min and max functions

["GeordieMai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810293#comment-17810293 ] 

GeordieMai commented on YUNIKORN-2335:
--------------------------------------

hi [~wilfreds] 
I am a newbie, Can I take this?

> Use go standard library min and max functions
> ---------------------------------------------
>
>                 Key: YUNIKORN-2335
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2335
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: core - common
>            Reporter: Wilfred Spiegelenburg
>            Priority: Major
>              Labels: newbie
>
> Go 1.21 introduced standard min and max builtin functions.
> We should remove the following functions:
>  * MaxQuantity (resources)
>  * MinQuantity (resources)
>  * min (ring buffer)
>  * Min (common utils)
> Replace with min and max builtin functions.
> NOTE: this requires a go directive change in the go.mod file to move to 1.21 as the minimum version. This needs to be coordinates for the different repos.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org