Re: [PR] feature: add HMAC-SHA256 mutual authentication between NamingServer and Server [incubator-seata]

["slievrly (via GitHub)" <gi...@apache.org>]

slievrly commented on code in PR #8185:
URL: https://github.com/apache/incubator-seata/pull/8185#discussion_r4167399826


##########
server/pom.xml:
##########
@@ -135,6 +135,12 @@
             <groupId>javax.servlet</groupId>
             <artifactId>javax.servlet-api</artifactId>
         </dependency>
+        <!-- Jakarta Servlet API required by the security auth filter, aligned with Spring Boot 4.x. -->

Review Comment:
   Fixed in 5ab7dcca4: removed the unused javax.servlet-api dependency. Server sources use jakarta.servlet and retain the Jakarta API dependency. The server reactor compiles successfully. I also rechecked the other inline comments against the current head: immutable registry snapshots, unambiguous nonce keys, route boundaries, JSON escaping and the canonicalization comment have already been corrected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org