You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/07 11:00:06 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7123: ARROW-8728: [C++] Fix bitmap operation buffer overflow

pitrou commented on a change in pull request #7123:
URL: https://github.com/apache/arrow/pull/7123#discussion_r421418632



##########
File path: cpp/src/arrow/util/bit_util_test.cc
##########
@@ -577,7 +577,7 @@ class BitmapOp : public TestBase {
     std::shared_ptr<Buffer> left, right, out;
     int64_t length;
 
-    for (int64_t left_offset : {0, 1, 3, 5, 7, 8, 13, 21, 38, 75, 120}) {
+    for (int64_t left_offset : {0, 1, 3, 5, 7, 8, 13, 21, 38, 75, 120, 65536}) {

Review comment:
       This test would fail without the fix?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org