You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by thygesen <gi...@git.apache.org> on 2017/02/15 20:16:33 UTC

[GitHub] opennlp pull request #125: OPENNLP-229: Write a test case for the NameFinder...

GitHub user thygesen opened a pull request:

    https://github.com/apache/opennlp/pull/125

    OPENNLP-229: Write a test case for the NameFinderSequenceValidator class

    I have written the missing test for NameFinderSequenceValidator. Please note that the test:testContinueAfterStartAndNotSameType has temporary been disabled because it will fail due to a minor "bug" in the NameFinderSequenceValidator. At the moment the validator accepts Continue after Start even though they are different name types. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thygesen/opennlp opennlp-229

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 5c29df047778fb1ac3d9773c27c001291a52112c
Author: Peter Thygesen <pe...@gmail.com>
Date:   2017-02-15T20:12:48Z

    Added test for NameFinderSequenceValidator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] opennlp pull request #125: OPENNLP-229: Write a test case for the NameFinder...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/opennlp/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---