[GitHub] [shardingsphere] sandynz commented on a diff in pull request #18069: Fix #18064, check illegal value

[GitBox <gi...@apache.org>]

sandynz commented on code in PR #18069:
URL: https://github.com/apache/shardingsphere/pull/18069#discussion_r885216839


##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java:
##########
@@ -153,36 +155,46 @@ private String readColumnType(final ByteBuffer data) {
     }
     
     private Object readColumnData(final ByteBuffer data, final String columnType) {
-        if (columnType.startsWith("numeric")) {
-            return new BigDecimal(readNextSegment(data));
-        }
         if (columnType.startsWith("bit") || columnType.startsWith("bit varying")) {
             return readNextSegment(data);
         }

Review Comment:
   Does "bit" and "bit varying" need to do the same change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org