You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eli Marmor <ma...@elmar.co.il> on 1999/11/19 14:09:11 UTC

src/helpers/binbuild.sh

Hello,

The following patch helps "src/helpers/binbuild.sh" to build a much
smaller tar.gz file. The current size is hundreds percents bigger than
after the patch. Let me know if there is any consideration against it
(the lines beginning with "+ " may be broken):


--- src/helpers/binbuild.sh.orig     Fri Aug 13 06:26:29 1999
+++ src/helpers/binbuild.sh          Fri Nov 19 14:46:52 1999
@@ -265,11 +265,11 @@
 else
   if [ "x$GTAR" != "x" ]
   then
-    $GTAR -zcf ../apache_$VER-$OS.tar.gz -C .. apache_$VER
+    $GTAR -zcf ../apache_$VER-$OS.tar.gz -C .. apache_$VER/bindist apache_$VER/install-bindist.sh build.log README.bindist config.status
   else
     if [ "x$TAR" != "x" ]
     then
-      $TAR -cf ../apache_$VER-$OS.tar -C .. apache_$VER
+      $TAR -cf ../apache_$VER-$OS.tar -C .. apache_$VER/bindist apache_$VER/install-bindist.sh build.log README.bindist config.status
       if [ "x$GZIP" != "x" ]
       then
         $GZIP ../apache_$VER-$OS.tar


In addition, it will be very useful and flexible to add
"$XTRA_CONFIGPARAM_FLAGS" to the definition of "CONFIGPARAM=" (line
10); It will allow builders to add their own special build flags
without modifying src/helpers/binbuild.sh.

-- 
Eli Marmor
marmor@elmar.co.il

Re: src/helpers/binbuild.sh

Posted by Lars Eilebrecht <la...@hyperreal.org>.
According to Manoj Kasichainula:

[...]
>  Your patch essentially eliminates the source tree from the binary
>  tarball, right? The source is included on purpose; and yes, this has
>  been argued back and forth before. The anti-includers think it's a
>  waste to bundle source for people who will never use it; the
>  pro-includers disagree.
[...]
>  If special flags are required to make a build complete properly, they
>  should be put into Apache proper, so that people compiling from source
>  don't have to worry about them. In any other case, all that would
>  serve to do is reduce the consistency of the binary builds, so I'm
>  against it.

I'll second that.

ciao...
-- 
Lars Eilebrecht                - I am fully operational and all of
lars@hyperreal.org           - my circuits are funcTiOnINg pperrf...


Re: src/helpers/binbuild.sh

Posted by Manoj Kasichainula <ma...@io.com>.
On Fri, Nov 19, 1999 at 03:09:11PM +0200, Eli Marmor wrote:
> The following patch helps "src/helpers/binbuild.sh" to build a much
> smaller tar.gz file.

Your patch essentially eliminates the source tree from the binary
tarball, right? The source is included on purpose; and yes, this has
been argued back and forth before. The anti-includers think it's a
waste to bundle source for people who will never use it; the
pro-includers disagree.

> In addition, it will be very useful and flexible to add
> "$XTRA_CONFIGPARAM_FLAGS" to the definition of "CONFIGPARAM=" (line
> 10); It will allow builders to add their own special build flags
> without modifying src/helpers/binbuild.sh.

If special flags are required to make a build complete properly, they
should be put into Apache proper, so that people compiling from source
don't have to worry about them. In any other case, all that would
serve to do is reduce the consistency of the binary builds, so I'm
against it.

-- 
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/