You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Chris Medaglia (JIRA)" <ji...@apache.org> on 2011/03/24 21:26:05 UTC
[jira] [Created] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
In python bindings, zookeeper.set2() should return a stat dict but instead returns None
---------------------------------------------------------------------------------------
Key: ZOOKEEPER-1028
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
Project: ZooKeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.3.3
Environment: All environments.
Reporter: Chris Medaglia
Priority: Minor
Fix For: 3.3.4
There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016802#comment-13016802 ]
Hudson commented on ZOOKEEPER-1028:
-----------------------------------
Integrated in ZooKeeper-trunk #1146 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1146/])
ZOOKEEPER-1028. In python bindings, zookeeper.set2() should return a stat dict but instead returns None. (Chris Medaglia and Ivan Kelly via mahadev)
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Chris Medaglia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012964#comment-13012964 ]
Chris Medaglia commented on ZOOKEEPER-1028:
-------------------------------------------
Hmm, sorry about that. When I made that change, the function returned the stat dict properly, whereas prior to the change, it just returned None. Thanks for taking a closer look and finding a better solution.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Chris Medaglia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012098#comment-13012098 ]
Chris Medaglia commented on ZOOKEEPER-1028:
-------------------------------------------
Yeah, absolutely!! I wasn't sure what to put for versions, so I just picked something after 3.3.3. :-)
Thanks for reviewing, I'll go ahead and submit the patch now.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Chris Medaglia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Medaglia updated ZOOKEEPER-1028:
--------------------------------------
Attachment: ZOOKEEPER-1028.patch
The patch includes the change to zookeeper.c and to get_set_test.py.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.3.4
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012110#comment-13012110 ]
Hadoop QA commented on ZOOKEEPER-1028:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474554/ZOOKEEPER-1028.patch
against trunk revision 1082362.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/207//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/207//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/207//console
This message is automatically generated.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Chris Medaglia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010961#comment-13010961 ]
Chris Medaglia commented on ZOOKEEPER-1028:
-------------------------------------------
Could someone do a code review on this prior to me submitting the patch?
Many thanks,
Chris
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.3.4
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1028:
-------------------------------------
Fix Version/s: (was: 3.3.4)
3.4.0
Assignee: Chris Medaglia
chris, 3.4.0 is the upcoming release, so I marked this fix for 3.4. Would that work?
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Chris Medaglia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Medaglia updated ZOOKEEPER-1028:
--------------------------------------
Description: There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'. (was: There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such the return value is '&stat' rather than 'stat'.)
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.3.4
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011925#comment-13011925 ]
Mahadev konar commented on ZOOKEEPER-1028:
------------------------------------------
the patch looks good to me!
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012908#comment-13012908 ]
Ivan Kelly commented on ZOOKEEPER-1028:
---------------------------------------
This fix is wrong.
Compilation gives a warning about invalid type being passed.
A good fix would be to change "struct Stat *stat = NULL"; to "struct Stat;" and pass &stat to zoo_set2. I've attached a patch to this effect. The current implementation passes a NULL pointer to zoo_set2, which means the stat never gets set.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated ZOOKEEPER-1028:
----------------------------------
Attachment: ZOOKEEPER-1028.diff
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1028) In python bindings,
zookeeper.set2() should return a stat dict but instead returns None
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012917#comment-13012917 ]
Hadoop QA commented on ZOOKEEPER-1028:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474959/ZOOKEEPER-1028.diff
against trunk revision 1082362.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/210//console
This message is automatically generated.
> In python bindings, zookeeper.set2() should return a stat dict but instead returns None
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1028
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1028
> Project: ZooKeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.3
> Environment: All environments.
> Reporter: Chris Medaglia
> Assignee: Chris Medaglia
> Priority: Minor
> Labels: patch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-1028.diff, ZOOKEEPER-1028.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There is a small bug in the python bindings, specifically with the zookeeper.set2() call. This method should return a stat dictionary, but actually returns None. The fix is a one-character change to zookeeper.c such that the return value is '&stat' rather than 'stat'.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira