You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2019/09/04 23:00:09 UTC
[jira] [Commented] (TEZ-4075) Tez: Reimplement
tez.runtime.transfer.data-via-events.enabled
[ https://issues.apache.org/jira/browse/TEZ-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922924#comment-16922924 ]
TezQA commented on TEZ-4075:
----------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 71m 57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 55s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 18s{color} | {color:orange} tez-api: The patch generated 1 new + 8 unchanged - 0 fixed = 9 total (was 8) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 25s{color} | {color:orange} tez-runtime-library: The patch generated 216 new + 226 unchanged - 4 fixed = 442 total (was 230) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 17s{color} | {color:orange} tez-tests: The patch generated 5 new + 55 unchanged - 0 fixed = 60 total (was 55) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 51s{color} | {color:red} tez-runtime-library generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 16s{color} | {color:red} tez-runtime-library in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 16s{color} | {color:green} tez-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 32m 25s{color} | {color:red} tez-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 2s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:tez-runtime-library |
| | Inconsistent synchronization of org.apache.tez.runtime.library.common.sort.impl.FileBackedBoundedByteArrayOutputStream.bufferIsFull; locked 50% of time Unsynchronized access at FileBackedBoundedByteArrayOutputStream.java:50% of time Unsynchronized access at FileBackedBoundedByteArrayOutputStream.java:[line 207] |
| | Inconsistent synchronization of org.apache.tez.runtime.library.common.sort.impl.FileBackedBoundedByteArrayOutputStream.rawOut; locked 75% of time Unsynchronized access at FileBackedBoundedByteArrayOutputStream.java:75% of time Unsynchronized access at FileBackedBoundedByteArrayOutputStream.java:[line 208] |
| | org.apache.tez.runtime.library.common.sort.impl.IFile$Writer.getTmpDataBuffer() may expose internal representation by returning IFile$Writer.tmpDataBuffer At IFile.java:by returning IFile$Writer.tmpDataBuffer At IFile.java:[line 544] |
| Failed junit tests | tez.runtime.library.common.writers.TestUnorderedPartitionedKVWriter |
| | tez.test.TestTezJobs |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/tez:d4a62deee |
| JIRA Issue | TEZ-4075 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12979478/Tez-4075.5.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc |
| uname | Linux f04d3906886d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | master / 7a3e378 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_222 |
| findbugs | v3.0.1 |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/diff-checkstyle-tez-api.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/diff-checkstyle-tez-runtime-library.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/diff-checkstyle-tez-tests.txt |
| whitespace | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/whitespace-tabs.txt |
| findbugs | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/new-findbugs-tez-runtime-library.html |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/patch-unit-tez-runtime-library.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/156/artifact/out/patch-unit-tez-tests.txt |
| Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/156/testReport/ |
| Max. process+thread count | 1195 (vs. ulimit of 5500) |
| modules | C: tez-api tez-runtime-library tez-examples tez-tests U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/156/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Tez: Reimplement tez.runtime.transfer.data-via-events.enabled
> -------------------------------------------------------------
>
> Key: TEZ-4075
> URL: https://issues.apache.org/jira/browse/TEZ-4075
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Gopal V
> Assignee: Richard Zhang
> Priority: Major
> Attachments: Tez-4075.5.patch
>
>
> This was factored out by TEZ-2196, which does skip buffers for 1-partition data exchanges (therefore goes to disk directly).
> {code}
> if (shufflePayload.hasData()) { shuffleManager.addKnownInput(shufflePayload.getHost(),
> DataProto dataProto = shufflePayload.getData(); shufflePayload.getPort(), srcAttemptIdentifier, srcIndex);
> FetchedInput fetchedInput = inputAllocator.allocate(dataProto.getRawLength(),
> dataProto.getCompressedLength(), srcAttemptIdentifier);
> moveDataToFetchedInput(dataProto, fetchedInput, hostIdentifier);
> shuffleManager.addCompletedInputWithData(srcAttemptIdentifier, fetchedInput);
> } else {
> shuffleManager.addKnownInput(shufflePayload.getHost(),
> shufflePayload.getPort(), srcAttemptIdentifier, srcIndex);
> }
> {code}
> got removed in
> https://github.com/apache/tez/commit/1ba1f927c16a1d7c273b6cd1a8553e5269d1541a
> It would be better to buffer up the 512Byte limit for the event size before writing to disk, since creating a new file always incurs disk traffic, even if the file is eventually being served out of the buffer cache.
> The total overhead of receiving an event, then firing an HTTP call to fetch the data etc adds approx 100-150ms to a query - the data xfer through the event will skip the disk entirely for this & also remove the extra IOPS incurred.
> This channel is not suitable for large-scale event transport, but specifically the workload here deals with 1-row control tables which consume more bandwidth with HTTP headers and hostnames than the 93 byte payload.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)