[GitHub] [phoenix] priyankporwal commented on a change in pull request #612: PHOENIX-5527 Unverified index rows should not be deleted due to repli…

[GitBox <gi...@apache.org>]

priyankporwal commented on a change in pull request #612: PHOENIX-5527 Unverified index rows should not be deleted due to repli…
URL: https://github.com/apache/phoenix/pull/612#discussion_r340323602
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
 ##########
 @@ -719,6 +722,23 @@ public void postBatchMutateIndispensably(ObserverContext<RegionCoprocessorEnviro
           for (RowLock rowLock : context.rowLocks) {
               rowLock.release();
           }
+          // Sleep for one millisecond if we have done the data table updates in less than 1 ms. The sleep is necessary
+          // not to allow another data table write on the same row within the same ms. The sleep is very rare to happen.
+          // Assume that a data table write completes at timestamp t.  Now assume another write happens on the same data
+          // row at timestamp t+1. The mutation for unverifying the index table row(s) for the previous write will have
 
 Review comment:
   Nit: Repharse, this as " On second update to the row, 
   the mutation for unverifying the index table row(s) for the previous write ....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services