You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Istvan Toth (Jira)" <ji...@apache.org> on 2021/02/01 14:56:00 UTC
[jira] [Commented] (PHOENIX-6353) Fix phoenix-thirdparty rat
warnings, and update CHANGES.md, RELEASE_NOTES.md
[ https://issues.apache.org/jira/browse/PHOENIX-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276384#comment-17276384 ]
Istvan Toth commented on PHOENIX-6353:
--------------------------------------
I pushed the CHANGELOG fix as an addendum to PHOENIX-6307
> Fix phoenix-thirdparty rat warnings, and update CHANGES.md, RELEASE_NOTES.md
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-6353
> URL: https://issues.apache.org/jira/browse/PHOENIX-6353
> Project: Phoenix
> Issue Type: Bug
> Components: thirdparty
> Affects Versions: thirdparty-1.1.0
> Reporter: Istvan Toth
> Priority: Minor
>
> As found by Ankit during the release vote check:
> bq. * apache-rat:check check failed for following files (it's better we remove
> bq. them):-
> bq.
> bq. phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
> bq.
> I'm not sure we can or should an ASF header on a patch file, but we can exclude it from RAT.
> bq.
> bq. phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
> This is unpacked from the commons-cli maven source artifact, exclude it from RAT
> bq. * Distribution link for the vote has a typo, the correct link seems to be
> bq. https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
> bq. * RELEASE notes and changes.md seems to be not updated from the last
> bq. release.
> It's a bug in the release scripts, I already have the fix, will open a JIRA for them ASAP.
> bq. * Signature and checksum - Ok
> bq. * Licence and Notice(nit: Copyright 2021) - Ok
> Need to update
--
This message was sent by Atlassian Jira
(v8.3.4#803005)