You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/03/14 10:09:32 UTC
Review Request 44783: HIVE-13183: More logs in operation logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs
-----
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
itests/hive-unit/src/test/java/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java de66d9efb1cace9d32174e3020920d5e4002dc85
itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java 9765b9dbe1ae097c108437c85b11b7bcee8f49da
ql/src/java/org/apache/hadoop/hive/ql/Driver.java b50c5a2c4e396975f3323b16426445f869ff7b89
ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java c87c825f95d2ff49bc62f892eb1cea5abf3c65c6
ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 4933b34710afebde923b548572ffd7f98b7eb728
ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 5253521557d09f12163624606373d64cde005d70
ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java e199e5ee65404d2e9a38d20fa9d2ff72754962e9
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java ce020a52721b439c4a9a81ee75e9829f2da00221
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 5bc3d9e732330af7890d7379334ed42be116ccbe
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java dd59bf275eecea178b8154962a79a385b02fda40
ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java 45cd533270a550ae07510fe3974ddceaed30af51
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java e9e9d0b314e9f9f2ac8e27689f48ed1077afa36c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java d39744b95cc51fa3042d019fb3bd05136d5dedc3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 607eb4fd1b69390010914af236e92a34428e2088
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java c36aa9de2549bceeb6fcf048fe2b56fe74fbe51b
ql/src/java/org/apache/hadoop/hive/ql/parse/QB.java 91352b22d0663b928e6f4f655914bdcf44cfa65c
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 633c212bc32bff68a63a6e7552cfde741c5553e5
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
ql/src/test/queries/clientnegative/authorization_view_5.q PRE-CREATION
ql/src/test/queries/clientnegative/authorization_view_6.q PRE-CREATION
ql/src/test/queries/clientnegative/authorization_view_7.q PRE-CREATION
ql/src/test/queries/clientnegative/authorization_view_disable_cbo_5.q PRE-CREATION
ql/src/test/queries/clientnegative/authorization_view_disable_cbo_6.q PRE-CREATION
ql/src/test/queries/clientnegative/authorization_view_disable_cbo_7.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_2.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_3.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_4.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_disable_cbo_2.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_disable_cbo_3.q PRE-CREATION
ql/src/test/queries/clientpositive/authorization_view_disable_cbo_4.q PRE-CREATION
ql/src/test/queries/clientpositive/vector_udf1.q PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_5.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_6.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_7.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_disable_cbo_5.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_disable_cbo_6.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_view_disable_cbo_7.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_3.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_4.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_disable_cbo_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_disable_cbo_3.q.out PRE-CREATION
ql/src/test/results/clientpositive/authorization_view_disable_cbo_4.q.out PRE-CREATION
ql/src/test/results/clientpositive/subquery_views.q.out 6ab2ad0e670bd03cb5a61e3f16b2780845faa991
ql/src/test/results/clientpositive/tez/explainuser_1.q.out a3ff85ca967e18529d8addfff2375bb797bc44fa
ql/src/test/results/clientpositive/vector_udf1.q.out PRE-CREATION
service-rpc/if/TCLIService.thrift 0aa9d13464bf284a3048092372299efb8e1d6bcc
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h 53642939829ec137db6b5ded46c6c3edef3b9e69
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp e62e8b720e967dac6bbd4f53328a85256a07e022
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java a7a8ebc5c663961e6f4ebdb9df78fa3d53e31d98
service-rpc/src/gen/thrift/gen-php/Types.php 76805df4910a31636dccbd119abe91dfbb1568a1
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py ef5f5f568ffec92c093bdd0904c154f8ee67606e
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb f004ec40afd29ab4ed452f65f306cb1af5ff5207
service/src/jamon/org/apache/hive/tmpl/QueryProfileTmpl.jamon c51368947ffe5873c727fc7e74aa25e748707370
service/src/java/org/apache/hive/service/cli/OperationStatus.java e45b828193daf46e26c1587f7e0b9ea1a43f4930
service/src/java/org/apache/hive/service/cli/operation/Operation.java 22f725c948494865e176a8d18543caf462a77c19
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 100dc6a5ceb10bff1d6591dd4b92062f4d787b98
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 8dff26467260c365d5869d5b3e3bae15c3acd92d
service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 5f01165d0dfd131a2599b90a8e1c4d4970650b7a
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java e78181a15993d99f1cab5a061c08bb21823d2171
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
(Updated April 4, 2016, 6:49 p.m.)
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 310356c526149088b2c1fc5dc4c1da3cbf166595
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 38996a7363a51bc055a0e5d0975780666f8c15bb
ql/src/test/results/clientpositive/llap/tez_join_hash.q.out 54ca9d219c532b76c92c91e620f357b99916f58d
ql/src/test/results/clientpositive/tez/tez_join_hash.q.out 8d0aba19d63a51c3d21f356078b74363ce8fc967
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
(Updated March 17, 2016, 1:08 a.m.)
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 310356c526149088b2c1fc5dc4c1da3cbf166595
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
(Updated March 16, 2016, 12:51 p.m.)
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c9924333d7fe84ceb35d1d1249d8e8fca31b9352
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
llap-server/src/java/org/apache/hadoop/hive/llap/IncrementalObjectSizeEstimator.java d33f7242c1407c3c37feb60d1e31fb5b22df6c55
llap-server/src/java/org/apache/hadoop/hive/llap/cache/Cache.java cee23a928bdc0e7046dd1cae26f613e4426aeb1c
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCache.java 17d9fdf264129d8789fea2ed44799d105ba79b6d
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 1132171b91d61447f58df627713f830f8572ccbf
llap-server/src/java/org/apache/hadoop/hive/llap/cache/NoopCache.java d0461e831727b252464a3f4ed371e798fabc694d
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java d2c19079c40ebf798fbecf1b3b0169e313ca9f50
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java b81e97d0c859035ccf02da28f0ac4b0a9fd443d5
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java 18191da6e06fd61e8e12d4f32220c1c17de70528
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java 28cae87146b07fadf8fcaaf558594fd89367935c
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java bcee56b0a082d5543e0f8fbe1378b90f89ea4946
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java 2e4e0c557caf9aa57debbfa51adc1b40d2017a1e
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcMetadataCache.java 43c8fb368f8e67a7944b42de3e81e9eaddd51c13
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 8479d225ddf6599790f9f57ff4401b9ac3dbac0b
metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java ec0be2bb18efdf5f4d72de2d3cb805d973dcc8b3
metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java bd4e188f582149a819352a30d2bb3271f6ab0e39
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java f0bc560f0bc0d43aaeb67f318e38a0b40fde2c67
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 9048d45423fee465ee03181d7ff8b5f4c1df9b3f
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 62677d127f8d306eeb4706e213ac3c64c638fd66
metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 1b388aab7247648ccdc04f6b080e3c5e71641a90
orc/src/java/org/apache/orc/FileMetadata.java d63bdccb20eda4a4b49ea83718340cf9e6d61422
orc/src/java/org/apache/orc/impl/InStream.java b1c6de59e7e96bb648584bb81563d53b8956b4c0
orc/src/java/org/apache/orc/impl/OutStream.java 68ef7d47dffc44fd23d0800fcacd79b1fe089cf6
orc/src/test/org/apache/orc/impl/TestOutStream.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 310356c526149088b2c1fc5dc4c1da3cbf166595
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezJobMonitor.java 418a03e174358c6a125e84dda35a5c80e9199db7
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 2b50a2a464d1cb809971500ee204e7e1c5ba261b
ql/src/java/org/apache/hadoop/hive/ql/io/HdfsUtils.java af64fc8d9a5ebc00d159a56735b89597a270e22f
ql/src/java/org/apache/hadoop/hive/ql/io/SyntheticFileId.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/LocalCache.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetastoreExternalCachesByConf.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java ef76723950bad579808b8e3e74b77a4f0c334987
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 0ebcd2aeaf2cb1204a4798f9f4762487135b0b5a
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcNewInputFormat.java 2782d7e99de55fedfea7a6da19806eeaaf96bd37
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 4a27ee7b0018b0fc11e04d62a8fccace0629e4bd
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 6cec80ee968a503c48cdd487fe11ab31cc2aa592
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/OrcBatchKey.java da673a5a2c38e171b7d3c7abdd1e9626b458144f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/OrcCacheKey.java 9a0158ec0650206fff237338c0b84eaec09bf205
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 246ead61e5b2c5d0ab1de79181537926a5b0edda
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java b0ac5034f3af8519eb4a30c7efe0ca7e036647a7
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/StreamUtils.java 9ac53afa373d230d824b133464d4e3beff59e4fa
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 80208c2db57d22d1ab3ced813a68ff07d4988e74
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java f273d25dd9a1bd49e48e3c21f850d1518d977aec
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 9d139ba8e640d739ca69a291cf9b1fa6d3bb3897
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 4fafe8c3217ac5942f2bc044223b8e197e9285a8
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSplitElimination.java 7a93b545979e8ae79d6647aad342723346ef0929
ql/src/test/queries/clientpositive/annotate_stats_filter.q 436c0530d9479a5b533b37eedd71b01e840eb29f
ql/src/test/queries/clientpositive/encryption_drop_partition.q a26aa19aaa086703dc4b388f7f5c1f7c330f3864
ql/src/test/queries/clientpositive/encryption_drop_table.q 193beea635de236d59338043374cecb3e51f61c5
ql/src/test/results/clientpositive/annotate_stats_filter.q.out b09ad0392a3d3ed330b828023965329a3183e92a
ql/src/test/results/clientpositive/annotate_stats_join_pkfk.q.out ff952522b2140a4a27bf4e72bb38a00ae3000203
ql/src/test/results/clientpositive/annotate_stats_part.q.out 186f7af0b76cf7a9243671687647c4dce2aa8663
ql/src/test/results/clientpositive/encrypted/encryption_drop_partition.q.out 067bf823f096681c949dc19265955e6a5b0010de
ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out 55eefa0993eab1c6f52e1a8b10d98dc5d60c7a0e
ql/src/test/results/clientpositive/tez/explainuser_1.q.out b7a81742aa9b51f3aad5be48e6212d6c94f9865b
storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java 9046589b5f347d8504de86933adbb0d7290c6605
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java 3ef7abee134e8f9801c3009bdb7511b852aea51d
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/PredicateLeaf.java dc71db4fb221cc32fa603f1884688ea93f5aac74
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java be5e67ba23122bb5cddbd34217cc8abdf1bfa2cc
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/#review123610
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 15, 2016, 6:37 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44783/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 6:37 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13183
> https://issues.apache.org/jira/browse/HIVE-13183
>
>
> Repository: hive-git
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 310356c526149088b2c1fc5dc4c1da3cbf166595
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
> ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
>
> Diff: https://reviews.apache.org/r/44783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
(Updated March 15, 2016, 12:07 p.m.)
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 310356c526149088b2c1fc5dc4c1da3cbf166595
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/#review123391
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java (line 106)
<https://reviews.apache.org/r/44783/#comment185643>
Can you avoid printStackTrace() and change it log ?
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java (line 108)
<https://reviews.apache.org/r/44783/#comment185644>
Can we directly log instead of printStackTrace?
- Amareshwari Sriramadasu
On March 14, 2016, 9:23 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44783/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 9:23 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-13183
> https://issues.apache.org/jira/browse/HIVE-13183
>
>
> Repository: hive-git
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
> ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
> ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
>
> Diff: https://reviews.apache.org/r/44783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 44783: HIVE-13183: More logs in operation logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44783/
-----------------------------------------------------------
(Updated March 14, 2016, 2:53 p.m.)
Review request for hive.
Bugs: HIVE-13183
https://issues.apache.org/jira/browse/HIVE-13183
Repository: hive-git
Description
-------
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/StreamPrinter.java 72638fdb966a63c64e44f2d952ecc49b4b0b5121
ql/src/java/org/apache/hadoop/hive/ql/exec/TaskRunner.java f6fd08104f6d5a8c93bca1f5d77468096e823144
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java f5500a4c4ece56fcd756c9c2159169228e542a6e
ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java 2ecdde9799683cd104323af170d8905fb3005b9e
Diff: https://reviews.apache.org/r/44783/diff/
Testing
-------
Thanks,
Rajat Khandelwal