You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/17 04:00:56 UTC
Review Request 63064: Clean up State Machine CSS to handle long
messages
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/
-----------------------------------------------------------
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Clean up State Machine CSS to handle long messages
Diffs
-----
ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
Diff: https://reviews.apache.org/r/63064/diff/1/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
See screenshots.
File Attachments
----------------
Current
https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
Fixed
https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
Thanks,
David McLaughlin
Re: Review Request 63064: Clean up State Machine CSS to handle long
messages
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/#review188369
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Oct. 16, 2017, 9:06 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63064/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 9:06 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Clean up State Machine CSS to handle long messages
>
>
> Diffs
> -----
>
> ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
> ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
> ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
>
>
> Diff: https://reviews.apache.org/r/63064/diff/2/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Current
> https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
> Fixed
> https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63064: Clean up State Machine CSS to handle long
messages
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/#review188267
-----------------------------------------------------------
@ReviewBot retry
- David McLaughlin
On Oct. 17, 2017, 4:06 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63064/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 4:06 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Clean up State Machine CSS to handle long messages
>
>
> Diffs
> -----
>
> ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
> ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
> ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
>
>
> Diff: https://reviews.apache.org/r/63064/diff/2/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Current
> https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
> Fixed
> https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63064: Clean up State Machine CSS to handle long
messages
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/#review188264
-----------------------------------------------------------
Master (5b72398) is red with this patch.
./build-support/jenkins/build.sh
org.apache.aurora.scheduler.http.api.security.ShiroKerberosPermissiveAuthenticationFilterTest > testPermitsUnauthenticated FAILED
java.lang.RuntimeException
I1017 04:24:51.556 [ShutdownHook, SchedulerMain] Stopping scheduler services.
889 tests completed, 1 failed, 1 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 6' finished with non-zero exit value 137
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 23m 38s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 16, 2017, 9:06 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63064/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 9:06 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Clean up State Machine CSS to handle long messages
>
>
> Diffs
> -----
>
> ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
> ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
> ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
>
>
> Diff: https://reviews.apache.org/r/63064/diff/2/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Current
> https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
> Fixed
> https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63064: Clean up State Machine CSS to handle long
messages
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/#review188269
-----------------------------------------------------------
Ship it!
Master (5b72398) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 4:06 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63064/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 4:06 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Clean up State Machine CSS to handle long messages
>
>
> Diffs
> -----
>
> ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
> ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
> ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
>
>
> Diff: https://reviews.apache.org/r/63064/diff/2/
>
>
> Testing
> -------
>
> ./gradlew ui:lint
> ./gradlew ui:test
>
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Current
> https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
> Fixed
> https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63064: Clean up State Machine CSS to handle long
messages
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63064/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 4:06 a.m.)
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Changes
-------
Missed a commit.
Repository: aurora
Description
-------
Clean up State Machine CSS to handle long messages
Diffs (updated)
-----
ui/src/main/js/components/StateMachine.js 2da85f77d4f0a34adc1ddb291482afa1ea8e51f1
ui/src/main/sass/components/_layout.scss 4818ab26006af5ac9e54189bf9c88d771f9e9391
ui/src/main/sass/components/_state-machine.scss 804746d10a6972c3ec6eb09539b97f33ee20e15d
Diff: https://reviews.apache.org/r/63064/diff/2/
Changes: https://reviews.apache.org/r/63064/diff/1-2/
Testing
-------
./gradlew ui:lint
./gradlew ui:test
See screenshots.
File Attachments
----------------
Current
https://reviews.apache.org/media/uploaded/files/2017/10/17/442c4ffa-f0d7-494b-8b54-e8cf32141a75__Screen_Shot_2017-10-16_at_8.54.47_PM.png
Fixed
https://reviews.apache.org/media/uploaded/files/2017/10/17/42b3ca44-2c09-4da9-9165-1a4f12745b46__Screen_Shot_2017-10-16_at_8.59.27_PM.png
Thanks,
David McLaughlin