You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/01/22 11:59:11 UTC
[GitHub] [helix] AriVuolas opened a new pull request #1621: Fix the ConcurrentModificationException in ClusterEvent.java
AriVuolas opened a new pull request #1621:
URL: https://github.com/apache/helix/pull/1621
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Backport PR#785 to fix #784 to next 0.9.x release.
### Description
Fixes possible `ConcurrentModificationException` and `NullPointerException` when accessing `_eventAttributeMap ` in `ClusterEvent`. The `NullPointerException` can happen if one thread triggers resizing of the `_eventAttributeMap ` and while the resizing is in progress, another thread tries to access value which is not yet added to the resized map.
This is basically just cherry-picking commit for #785 to helix-0.9.x branch.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] AnatolyPopov commented on pull request #1621: Fix the ConcurrentModificationException in ClusterEvent.java
Posted by GitBox <gi...@apache.org>.
AnatolyPopov commented on pull request #1621:
URL: https://github.com/apache/helix/pull/1621#issuecomment-767415354
Hi @narendly, could you please clarify how to get this one merged and released if possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #1621: Fix the ConcurrentModificationException in ClusterEvent.java
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1621:
URL: https://github.com/apache/helix/pull/1621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] AnatolyPopov commented on pull request #1621: Fix the ConcurrentModificationException in ClusterEvent.java
Posted by GitBox <gi...@apache.org>.
AnatolyPopov commented on pull request #1621:
URL: https://github.com/apache/helix/pull/1621#issuecomment-767840260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1621: Fix the ConcurrentModificationException in ClusterEvent.java
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1621:
URL: https://github.com/apache/helix/pull/1621#issuecomment-767772269
Hi @AnatolyPopov - you can follow the procedures described here: https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps
Also, we aren't currently supporting 0.9.X versions and currently have no plans for future releases for 0.9+ versions. If you think there's a need, you can start a conversation in the Helix email thread: user@helix.apache.org. Alternatively, you could try to upgrade to the latest official release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org