You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "kerneltime (via GitHub)" <gi...@apache.org> on 2023/02/28 00:31:10 UTC
[GitHub] [ozone] kerneltime opened a new pull request, #4324: HDDS-7156: Reset pending delete block count
kerneltime opened a new pull request, #4324:
URL: https://github.com/apache/ozone/pull/4324
## What changes were proposed in this pull request?
Reset pending delete block count to 0 if a container has no transactions Each container has a counter that tracks the number of pending delete blocks in the delete_txns table for that container. In some cases, this counter can remain positive when all delete transactions are cleared, and the counter will never be reset. This means it will continue to be chosen for deletion instead of other containers that actually have delete txns.
After this change, if a container is chosen for deletion because it has
>0 pending delete block count but upon deleting from the container, it
is found that there are actually no delete txns, reset the pending delete block counter to 0. This way it will not be chosen for block deletion until it gets more delete transactions.
A new unit test for TestBlockDeletingService was added, and the whole TestBlockDeletingService suite passes.
Author: Ethan Rose
Change-Id: I43e6815962f2db83a95a396020cfa6b7195a8f5f
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7156
## How was this patch tested?
Unit tests included
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] arp7 commented on pull request #4324: HDDS-7156. Reset pending delete block count
Posted by "arp7 (via GitHub)" <gi...@apache.org>.
arp7 commented on PR #4324:
URL: https://github.com/apache/ozone/pull/4324#issuecomment-1450744466
+1 LGTM. Feel free to commit once CI comes back clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #4324: HDDS-7156. Reset pending delete block count
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #4324:
URL: https://github.com/apache/ozone/pull/4324#issuecomment-1450730144
LGTM, but I technically wrote these so someone else should officially +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime merged pull request #4324: HDDS-7156. Reset pending delete block count
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime merged PR #4324:
URL: https://github.com/apache/ozone/pull/4324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] symious commented on pull request #4324: HDDS-7156. Reset pending delete block count
Posted by "symious (via GitHub)" <gi...@apache.org>.
symious commented on PR #4324:
URL: https://github.com/apache/ozone/pull/4324#issuecomment-1463330155
Sorry for late reply, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #4324: HDDS-7156: Reset pending delete block count
Posted by "kerneltime (via GitHub)" <gi...@apache.org>.
kerneltime commented on PR #4324:
URL: https://github.com/apache/ozone/pull/4324#issuecomment-1447340315
This is related to and duplicated https://github.com/apache/ozone/pull/3703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org