You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/11 03:43:00 UTC
[jira] [Work logged] (AVRO-3603) .NET/#C: Refactor ReflectReader/Writer: add IReflectService, add DI
[ https://issues.apache.org/jira/browse/AVRO-3603?focusedWorklogId=799870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799870 ]
ASF GitHub Bot logged work on AVRO-3603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 03:42
Start Date: 11/Aug/22 03:42
Worklog Time Spent: 10m
Work Description: KhrystynaPopadyuk opened a new pull request, #1819:
URL: https://github.com/apache/avro/pull/1819
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
Issue Time Tracking
-------------------
Worklog Id: (was: 799870)
Remaining Estimate: 0h
Time Spent: 10m
> .NET/#C: Refactor ReflectReader/Writer: add IReflectService, add DI
> -------------------------------------------------------------------
>
> Key: AVRO-3603
> URL: https://issues.apache.org/jira/browse/AVRO-3603
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Khrystyna Popadyuk
> Assignee: Khrystyna Popadyuk
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current ReflectReader/Writer use a lot of static entities (classes, methods, fields). It is good to refactor them with interfaces and DI approach.
> If do such update at once it requires massive changes and can we difficult to review and test.
> This story is created as first step for such refactoring. It will include:
> - group classes by folders
> - rename (probably)
> - add IReflectService as main service to work with reflection
> - add DI
> - wrap ClassCash (avoid refactoring in scope of this story)
>
> This is breaking changes.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)