You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/12/24 12:39:21 UTC

[GitHub] [incubator-doris] imay commented on a change in pull request #2556: Fix Bug : Load parquet data during the upgrade may result in data errors

imay commented on a change in pull request #2556: Fix Bug : Load parquet data during the upgrade may result in data errors
URL: https://github.com/apache/incubator-doris/pull/2556#discussion_r361155968
 
 

 ##########
 File path: be/src/exec/parquet_scanner.cpp
 ##########
 @@ -74,13 +74,12 @@ Status ParquetScanner::get_next(Tuple* tuple, MemPool* tuple_pool, bool* eof) {
         const TBrokerRangeDesc& range = _ranges.at(_next_range - 1);
         if (range.__isset.num_of_columns_from_file) {
             fill_slots_of_columns_from_path(range.num_of_columns_from_file, range.columns_from_path);
-            {
-                COUNTER_UPDATE(_rows_read_counter, 1);
-                SCOPED_TIMER(_materialize_timer);
-                if (fill_dest_tuple(Slice(), tuple, tuple_pool)) {
-                    break;// break if true
-                }
-            }
+        }
+
+        COUNTER_UPDATE(_rows_read_counter, 1);
+        if (fill_dest_tuple(Slice(), tuple, tuple_pool)) {
+            SCOPED_TIMER(_materialize_timer);
 
 Review comment:
   put this out of if block

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org