You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gerashegalov <gi...@git.apache.org> on 2014/07/18 12:33:02 UTC
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
GitHub user gerashegalov opened a pull request:
https://github.com/apache/spark/pull/1483
[YARN] SPARK-2577: File upload to viewfs is broken due to mount point re...
Opting to the option 2 defined in SPARK-2577, i.e., retrieve and pass the correct file system object to addResource.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gerashegalov/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1483
----
commit 90c9087d1d6c9c29ced0575579528bfb1ab2f549
Author: Gera Shegalov <ge...@twitter.com>
Date: 2014-07-18T10:13:56Z
[YARN] SPARK-2577: File upload to viewfs is broken due to mount point resolution
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by gerashegalov <gi...@git.apache.org>.
Github user gerashegalov commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49835395
@tgravescs Sorry for coming late. I haven't tested on a secure cluster yet, only on my pseudo-distributed cluster. But since the viewfs implements getChildFileSystems, it should not be an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49605112
From my understanding when using viewfs: addDelegationTokens is supposed to get tokens for all the underlying filesystems so it should already have a token for it. @gerashegalov did you test this on secure cluster?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by sryza <gi...@git.apache.org>.
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49491293
@tgravescs do you know whether we need to do anything to fetch tokens for the destination filesystem? Otherwise the change looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49480308
QA tests have started for PR 1483. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16833/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49488793
QA results for PR 1483:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16833/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49825078
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49479880
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [YARN] SPARK-2577: File upload to viewfs is br...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1483#issuecomment-49417518
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---