You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by robdouglas <gi...@git.apache.org> on 2014/09/18 17:48:45 UTC
[GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
GitHub user robdouglas opened a pull request:
https://github.com/apache/incubator-streams/pull/90
STREAMS-178 | Modified the behavior of the LinkResolverProcessor's unwin...
...d method. Duplicate unwound links are now consolidated into a unique set of links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robdouglas/incubator-streams STREAMS-178
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit f76f2de5923e63405229e2c83acc12156fe0c8de
Author: Robert Douglas <rd...@w2odigital.com>
Date: 2014-09-18T15:46:23Z
STREAMS-178 | Modified the behavior of the LinkResolverProcessor's unwind method. Duplicate unwound links are now consolidated into a unique set of links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
Posted by sieverssj <gi...@git.apache.org>.
Github user sieverssj commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/90#discussion_r17735841
--- Diff: streams-contrib/streams-processor-urls/src/test/java/org/apache/streams/urls/TestLinkUnwinderProcessor.java ---
@@ -76,8 +76,8 @@ public void testActivityLinkUnwinderProcessorGoDaddy() throws Exception{
@Test
public void testActivityLinkUnwinderProcessorMulti() throws Exception{
- testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte", "http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/", "http://www.wcgworld.com/", "http://www.wcgworld.com/"));
- testStringActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte", "http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/", "http://www.wcgworld.com/", "http://www.wcgworld.com/"));
+ testActivityUnwinderHelper(Lists.newArrayList("http://x.co/3yapt", "http://ow.ly/u4Kte", "http://goo.gl/wSrHDA"), Lists.newArrayList("http://www.wcgworld.com/"));//, "http://www.wcgworld.com/", "http://www.wcgworld.com/"));
--- End diff --
Small nit: Get rid of the commented out code on the end of these lines.
Assuming that happens, :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on the pull request:
https://github.com/apache/incubator-streams/pull/90#issuecomment-56060108
Responded to code review feedback
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-178 | Modified the behavio...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/90#issuecomment-56713006
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---