You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/29 11:18:00 UTC
[GitHub] [superset] ktmud opened a new pull request #12828: chore: update capitalization guideline
ktmud opened a new pull request #12828:
URL: https://github.com/apache/superset/pull/12828
### SUMMARY
Update capitalization guideline to exempt user inputs from cap transformation.
Based on the discussion here: https://github.com/apache/superset/issues/12343#issuecomment-756482628
cc @mihir174
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc merged pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
junlincc merged pull request #12828:
URL: https://github.com/apache/superset/pull/12828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
+ Coverage 66.65% 66.86% +0.21%
==========================================
Files 1021 1021
Lines 50125 50125
Branches 5190 5190
==========================================
+ Hits 33411 33517 +106
+ Misses 16575 16474 -101
+ Partials 139 134 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <ø> (+4.02%)` | :arrow_up: |
| javascript | `62.00% <ø> (ø)` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.33% <0.00%> (+0.66%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.08% <0.00%> (+1.65%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-770103468
Related: https://github.com/apache/superset/issues/12829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **decrease** coverage by `3.60%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
- Coverage 66.65% 63.05% -3.61%
==========================================
Files 1021 1021
Lines 50125 50104 -21
Branches 5190 5190
==========================================
- Hits 33411 31591 -1820
- Misses 16575 18299 +1724
- Partials 139 214 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.00% <ø> (ø)` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [169 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **increase** coverage by `0.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
+ Coverage 66.65% 67.01% +0.36%
==========================================
Files 1021 1021
Lines 50125 50125
Branches 5190 5190
==========================================
+ Hits 33411 33593 +182
+ Misses 16575 16398 -177
+ Partials 139 134 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <ø> (+4.02%)` | :arrow_up: |
| javascript | `62.00% <ø> (ø)` | |
| python | `63.99% <ø> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-6.28%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.33% <0.00%> (+0.66%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.08% <0.00%> (+1.65%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `77.77% <0.00%> (+2.77%)` | :arrow_up: |
| [...e/components/controls/FilterControl/AdhocFilter.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyLmpz) | `96.92% <0.00%> (+3.07%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| ... and [26 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
+ Coverage 66.65% 66.86% +0.21%
==========================================
Files 1021 1021
Lines 50125 50125
Branches 5190 5190
==========================================
+ Hits 33411 33517 +106
+ Misses 16575 16474 -101
+ Partials 139 134 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <ø> (+4.02%)` | :arrow_up: |
| javascript | `62.00% <ø> (ø)` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.33% <0.00%> (+0.66%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.08% <0.00%> (+1.65%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **increase** coverage by `0.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
+ Coverage 66.65% 67.07% +0.42%
==========================================
Files 1021 1021
Lines 50125 50125
Branches 5190 5190
==========================================
+ Hits 33411 33623 +212
+ Misses 16575 16368 -207
+ Partials 139 134 -5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.87% <ø> (+4.02%)` | :arrow_up: |
| javascript | `62.00% <ø> (ø)` | |
| python | `64.09% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.33% <0.00%> (+0.66%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.08% <0.00%> (+1.65%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `77.77% <0.00%> (+2.77%)` | :arrow_up: |
| [...e/components/controls/FilterControl/AdhocFilter.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyLmpz) | `96.92% <0.00%> (+3.07%)` | :arrow_up: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `85.71% <0.00%> (+3.57%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `63.90% <0.00%> (+3.82%)` | :arrow_up: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `68.87% <0.00%> (+3.97%)` | :arrow_up: |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12828: chore: update capitalization guideline
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12828:
URL: https://github.com/apache/superset/pull/12828#issuecomment-769789483
# [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=h1) Report
> Merging [#12828](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=desc) (e534bae) into [master](https://codecov.io/gh/apache/superset/commit/e3db935c62d630729e9cbd4cbfa19aa592fdca70?el=desc) (e3db935) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12828 +/- ##
==========================================
+ Coverage 66.65% 66.78% +0.12%
==========================================
Files 1021 1021
Lines 50125 50125
Branches 5190 5190
==========================================
+ Hits 33411 33474 +63
+ Misses 16575 16513 -62
+ Partials 139 138 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.50% <ø> (+3.65%)` | :arrow_up: |
| javascript | `62.00% <ø> (ø)` | |
| python | `63.74% <ø> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-7.15%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...c/dashboard/components/nativeFilters/FilterBar.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyLnRzeA==) | `51.33% <0.00%> (+0.66%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | `98.03% <0.00%> (+1.96%)` | :arrow_up: |
| [...frontend/src/dashboard/reducers/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRMYXlvdXQuanM=) | `99.00% <0.00%> (+2.00%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | `77.77% <0.00%> (+2.77%)` | :arrow_up: |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/12828/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=footer). Last update [e3db935...e534bae](https://codecov.io/gh/apache/superset/pull/12828?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org