You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/10/22 10:03:27 UTC
[GitHub] [kylin] zhangayqian opened a new pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
zhangayqian opened a new pull request #1754:
URL: https://github.com/apache/kylin/pull/1754
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :
1. The original branch _kylin-on-parquet-v2_ for **Kylin 4.X** (Parquet Storage) has been renamed to branch **main**, and configured as the **default** branch;
2. The original branch _master_ for **Kylin 3.X** (HBase Storage) has been renamed to branch **kylin3** ;
Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1754:
URL: https://github.com/apache/kylin/pull/1754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-950819862
This pull request **fixes 1 alert** when merging f6d44a93fc95753f2bce163fb10844b35141696d into df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-a82a42a1898ce162e1d617ab4bed5a1a12200e90)
**fixed alerts:**
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-954464665
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`main@df6dd47`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1754 +/- ##
=======================================
Coverage ? 24.58%
Complexity ? 4416
=======================================
Files ? 1090
Lines ? 61699
Branches ? 8856
=======================================
Hits ? 15169
Misses ? 44924
Partials ? 1606
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1754?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1754?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df6dd47...671763f](https://codecov.io/gh/apache/kylin/pull/1754?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-949505046
This pull request **fixes 1 alert** when merging cbed5207f207d15286d49cea0496597b3d2fb058 into df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-7410cf5bd646b485e954081b91402938487dc28c)
**fixed alerts:**
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-950659003
This pull request **fixes 1 alert** when merging 2b044b8041a9075e66c3f8f01b99a96023b1cc7d into df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-e500e3adbc08cf4b43a4ec9d5dd635bad63338d2)
**fixed alerts:**
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-950583015
This pull request **fixes 1 alert** when merging 5ca2dcaa2f4e39877cf21d73ea433d18312bebdb into df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-eb3b2a82c914e9b3d2dbc56cce00869b49f41058)
**fixed alerts:**
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on a change in pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on a change in pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#discussion_r735231481
##########
File path: build/bin/prepare_hadoop_denpendency.sh
##########
@@ -0,0 +1,192 @@
+#!/bin/bash
Review comment:
This filename is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1754: KYLIN-5069 Refactor hive and hadoop dependency of kylin4
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-954461257
This pull request **fixes 1 alert** when merging 671763f7bb92298cc956eda5d62f8fa43f3dfd1b into df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-e5fdec42d39ff59c1cf1985e85c3e9d4b3e64f8c)
**fixed alerts:**
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org