You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/01 16:07:37 UTC
[GitHub] [airflow] chenglongyan opened a new pull request, #24082: Migrate Yandex example DAGs to new design AIP-47
chenglongyan opened a new pull request, #24082:
URL: https://github.com/apache/airflow/pull/24082
closes: #22470
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bhirsz commented on a diff in pull request #24082: Migrate Yandex example DAGs to new design AIP-47
Posted by GitBox <gi...@apache.org>.
bhirsz commented on code in PR #24082:
URL: https://github.com/apache/airflow/pull/24082#discussion_r887646357
##########
tests/system/providers/yandex/example_yandexcloud_dataproc.py:
##########
@@ -153,3 +156,8 @@
create_cluster >> create_mapreduce_job >> create_hive_query >> create_hive_query_from_file
create_hive_query_from_file >> create_spark_job >> create_pyspark_job >> delete_cluster
Review Comment:
Shouldn't the ``delete_clusted`` be with ``Trigger_Rule.ALL_DONE``? (and then use watcher task to watch the status of the DAG). In case there is any failure in the DAG, we're left with clusted created by ``create_cluster`` task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24082: Migrate Yandex example DAGs to new design AIP-47
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24082:
URL: https://github.com/apache/airflow/pull/24082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on a diff in pull request #24082: Migrate Yandex example DAGs to new design AIP-47
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on code in PR #24082:
URL: https://github.com/apache/airflow/pull/24082#discussion_r888518813
##########
tests/system/providers/yandex/example_yandexcloud_dataproc.py:
##########
@@ -153,3 +156,8 @@
create_cluster >> create_mapreduce_job >> create_hive_query >> create_hive_query_from_file
create_hive_query_from_file >> create_spark_job >> create_pyspark_job >> delete_cluster
Review Comment:
Thanks @bhirsz , i will push a commit to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org