You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2020/04/16 10:15:48 UTC
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/
-----------------------------------------------------------
(Updated April 16, 2020, 10:15 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2794
https://issues.apache.org/jira/browse/RANGER-2794
Repository: ranger
Description
-------
This issue occurs when we try to search roles by User Name or Group Name.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
Diff: https://reviews.apache.org/r/72366/diff/1/
Testing
-------
Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
Thanks,
Mahesh Bandal
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/#review220385
-----------------------------------------------------------
Ship it!
Ship It!
- bhavik patel
On April 20, 2020, 10:35 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72366/
> -----------------------------------------------------------
>
> (Updated April 20, 2020, 10:35 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2794
> https://issues.apache.org/jira/browse/RANGER-2794
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This issue occurs when we try to search roles by User Name or Group Name.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
>
>
> Diff: https://reviews.apache.org/r/72366/diff/2/
>
>
> Testing
> -------
>
> Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
>
>
> Thanks,
>
> Mahesh Bandal
>
>
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Mahesh Bandal <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/
-----------------------------------------------------------
(Updated April 22, 2020, 6:14 p.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2794
https://issues.apache.org/jira/browse/RANGER-2794
Repository: ranger
Description
-------
This issue occurs when we try to search roles by User Name or Group Name.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
security-admin/src/main/webapp/scripts/utils/XAUtils.js d02e077a0
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js cf5aff931
security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 2b8218170
Diff: https://reviews.apache.org/r/72366/diff/5/
Changes: https://reviews.apache.org/r/72366/diff/4-5/
Testing
-------
Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
Thanks,
Mahesh Bandal
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Mahesh Bandal <ma...@gmail.com>.
> On April 22, 2020, 6:52 a.m., Pradeep Agrawal wrote:
> > security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/72366/diff/4/?file=2224713#file2224713line41>
> >
> > what is "name" for here. is this role name ? if yes then what is for line 36 ?
"name" is query parameter coming from UI to search RoleName. (In case role lookup in add new policy and add new role)
- Mahesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/#review220413
-----------------------------------------------------------
On April 22, 2020, 6:09 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72366/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 6:09 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2794
> https://issues.apache.org/jira/browse/RANGER-2794
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This issue occurs when we try to search roles by User Name or Group Name.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
>
>
> Diff: https://reviews.apache.org/r/72366/diff/4/
>
>
> Testing
> -------
>
> Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
>
>
> Thanks,
>
> Mahesh Bandal
>
>
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/#review220413
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java
Lines 41 (patched)
<https://reviews.apache.org/r/72366/#comment308800>
what is "name" for here. is this role name ? if yes then what is for line 36 ?
- Pradeep Agrawal
On April 22, 2020, 6:09 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72366/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 6:09 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2794
> https://issues.apache.org/jira/browse/RANGER-2794
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This issue occurs when we try to search roles by User Name or Group Name.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
>
>
> Diff: https://reviews.apache.org/r/72366/diff/4/
>
>
> Testing
> -------
>
> Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
>
>
> Thanks,
>
> Mahesh Bandal
>
>
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Mahesh Bandal <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/
-----------------------------------------------------------
(Updated April 22, 2020, 6:09 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Added partial search
Bugs: RANGER-2794
https://issues.apache.org/jira/browse/RANGER-2794
Repository: ranger
Description
-------
This issue occurs when we try to search roles by User Name or Group Name.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
Diff: https://reviews.apache.org/r/72366/diff/4/
Changes: https://reviews.apache.org/r/72366/diff/3-4/
Testing
-------
Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
Thanks,
Mahesh Bandal
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Mahesh Bandal <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/
-----------------------------------------------------------
(Updated April 21, 2020, 9:35 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2794
https://issues.apache.org/jira/browse/RANGER-2794
Repository: ranger
Description
-------
This issue occurs when we try to search roles by User Name or Group Name.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
Diff: https://reviews.apache.org/r/72366/diff/3/
Changes: https://reviews.apache.org/r/72366/diff/2-3/
Testing
-------
Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
Thanks,
Mahesh Bandal
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/#review220386
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java
Lines 97 (patched)
<https://reviews.apache.org/r/72366/#comment308745>
1) if possible replace !isEmpty() with isNotEmpty() methods.
2) write "name".equals(name)
3) there should be a space after "if". like line 93
- Pradeep Agrawal
On April 20, 2020, 10:35 a.m., Mahesh Bandal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72366/
> -----------------------------------------------------------
>
> (Updated April 20, 2020, 10:35 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2794
> https://issues.apache.org/jira/browse/RANGER-2794
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This issue occurs when we try to search roles by User Name or Group Name.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
> security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
>
>
> Diff: https://reviews.apache.org/r/72366/diff/2/
>
>
> Testing
> -------
>
> Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
>
>
> Thanks,
>
> Mahesh Bandal
>
>
Re: Review Request 72366: RANGER-2794 : Search is not working in Role
page
Posted by Mahesh Bandal <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72366/
-----------------------------------------------------------
(Updated April 20, 2020, 10:35 a.m.)
Review request for ranger, Ankita Sinha, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Added role lookup feature while adding new reference roles
Bugs: RANGER-2794
https://issues.apache.org/jira/browse/RANGER-2794
Repository: ranger
Description
-------
This issue occurs when we try to search roles by User Name or Group Name.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 98a8596c8
security-admin/src/main/java/org/apache/ranger/service/RangerRoleServiceBase.java 5b22a5361
Diff: https://reviews.apache.org/r/72366/diff/2/
Changes: https://reviews.apache.org/r/72366/diff/1-2/
Testing
-------
Searched for roles by applying filter such as 'User Name', 'Group Name', 'Role Name'. Search shows expected output.
Thanks,
Mahesh Bandal