You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/07 06:55:27 UTC
[GitHub] [druid] gianm opened a new pull request, #13040: Remove basePersistDirectory from tuning configs.
gianm opened a new pull request, #13040:
URL: https://github.com/apache/druid/pull/13040
Since the removal of CliRealtime, it serves no purpose, since it is always overridden in production using withBasePersistDirectory given some subdirectory of the task work directory.
Removing this from the tuning config has a benefit beyond removing no-longer-needed logic: it also avoids the side effect of empty "druid-realtime-persist" directories getting created in the systemwide temp directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #13040: Remove basePersistDirectory from tuning configs.
Posted by GitBox <gi...@apache.org>.
gianm merged PR #13040:
URL: https://github.com/apache/druid/pull/13040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #13040: Remove basePersistDirectory from tuning configs.
Posted by GitBox <gi...@apache.org>.
gianm commented on PR #13040:
URL: https://github.com/apache/druid/pull/13040#issuecomment-1287552292
> while reviewing this i started to wonder if `basePersistDirectory` should be on the `AppenderatorConfig` at all anymore since its never set directly so seems a bit strange as part of the base class, but looking into how painful that would be to move somewhere for not much gain it doesn't really seem worth the effort
That was my thinking as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org