You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/04/19 14:57:24 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

lordgamez opened a new pull request, #1562:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562

   Tested on a live AWS instance, when the `Use Path Style Access` was set to true, the `s3.eu-west-2.amazonaws.com` URL was used and the bucket name was set in the path (path style access), otherwise the virtual path URL was used `my-bucket.s3.eu-west-2.amazonaws.com`
   
   https://issues.apache.org/jira/browse/MINIFICPP-2106
   
   -----------------------------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1562:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1172145799


##########
extensions/aws/tests/MockS3RequestSender.h:
##########
@@ -250,6 +252,10 @@ class MockS3RequestSender : public minifi::aws::s3::S3RequestSender {
     return client_config_;
   }
 
+  bool getUserVirtualAddressing() const {

Review Comment:
   This looks like a typo
   ```suggestion
     bool getUseVirtualAddressing() const {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1562:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1172254661


##########
extensions/aws/tests/MockS3RequestSender.h:
##########
@@ -250,6 +252,10 @@ class MockS3RequestSender : public minifi::aws::s3::S3RequestSender {
     return client_config_;
   }
 
+  bool getUserVirtualAddressing() const {

Review Comment:
   Good catch, fixed in 70dd30bb57534a2eb38d3fc5cb76150900a8c076



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1562:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1172352494


##########
extensions/aws/processors/PutS3Object.cpp:
##########
@@ -73,6 +73,11 @@ void PutS3Object::onSchedule(const std::shared_ptr<core::ProcessContext> &contex
   }
   logger_->log_debug("PutS3Object: Server Side Encryption [%s]", server_side_encryption_);
 
+  bool use_path_style_access = false;
+  if (context->getProperty(UsePathStyleAccess.getName(), use_path_style_access)) {
+    use_virtual_addressing_ = !use_path_style_access;
+  }
+

Review Comment:
   Updated in 0cc5232b2bda754eefbc48f7f9ff99fca40131f1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1562: MINIFICPP-2106 Add 'Use Path Style Access' property to PutS3Object

Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1562:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1562#discussion_r1171511190


##########
extensions/aws/processors/PutS3Object.cpp:
##########
@@ -73,6 +73,11 @@ void PutS3Object::onSchedule(const std::shared_ptr<core::ProcessContext> &contex
   }
   logger_->log_debug("PutS3Object: Server Side Encryption [%s]", server_side_encryption_);
 
+  bool use_path_style_access = false;
+  if (context->getProperty(UsePathStyleAccess.getName(), use_path_style_access)) {
+    use_virtual_addressing_ = !use_path_style_access;
+  }
+

Review Comment:
   Nitpick but I think we could improve the readability and limit the scope of the use_path_style_access by using the optional returning getProperty
   ```suggestion
     if (auto use_path_style_access = context->getProperty<bool>(UsePathStyleAccess)) {
       use_virtual_addressing_ = !*use_path_style_access;
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org