You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2021/05/02 19:32:00 UTC
[kudu-CR] [test] fix flakiness in RegistrationTest.TestTSRegisters
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17377 )
Change subject: [test] fix flakiness in RegistrationTest.TestTSRegisters
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17377/1/src/kudu/integration-tests/registration-test.cc
File src/kudu/integration-tests/registration-test.cc:
http://gerrit.cloudera.org:8080/#/c/17377/1/src/kudu/integration-tests/registration-test.cc@a261
PS1, Line 261:
If the idea is to ensure that after restarting, we get a higher seqno, would it make sense to call this before the restart, and assert that post-restart we eventually get a higher seqno?
--
To view, visit http://gerrit.cloudera.org:8080/17377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b072409d2a68bc2ad621c1c021b0f4b3143fb2
Gerrit-Change-Number: 17377
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 02 May 2021 19:32:00 +0000
Gerrit-HasComments: Yes