[GitHub] [camel] simon-ras commented on a diff in pull request #10847: CAMEL-19491: aws2-sqs - use `ScheduledPollConsumerHealthCheck`

["simon-ras (via GitHub)" <gi...@apache.org>]

simon-ras commented on code in PR #10847:
URL: https://github.com/apache/camel/pull/10847#discussion_r1275459319


##########
components/camel-aws/camel-aws2-sqs/src/main/java/org/apache/camel/component/aws2/sqs/Sqs2Consumer.java:
##########
@@ -375,16 +371,6 @@ protected void doStart() throws Exception {
         }
 
         super.doStart();
-
-        // health-check is optional so discover and resolve
-        healthCheckRepository = HealthCheckHelper.getHealthCheckRepository(getEndpoint().getCamelContext(), "components",
-                WritableHealthCheckRepository.class);
-
-        if (healthCheckRepository != null) {
-            consumerHealthCheck = new Sqs2ConsumerHealthCheck(this, getRouteId());
-            consumerHealthCheck.setEnabled(getEndpoint().getComponent().isHealthCheckEnabled() && getEndpoint().getComponent().isHealthCheckConsumerEnabled());

Review Comment:
   This solution does not honor these configuration options. Should they be removed, or should I override `doBuild()` in order to only add the health check in case it is configured?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org