You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/06 16:57:01 UTC

[kudu-CR] [hms] Adjust storage handler package 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13540


Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_client.cc
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 6: Verified-1


-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:50:27 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Adjust storage handler package

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:42:04 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support for the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Reviewed-on: http://gerrit.cloudera.org:8080/13540
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 35 insertions(+), 10 deletions(-)

Approvals:
  Hao Hao: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG@9
PS4, Line 9: This patch changes the new KuduStorageHandler
> I think it is worth mentioning that this patch is not using the new KuduSto
I had to change this to make the migration work. It is using the new KuduStorageHandler now.


http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG@21
PS4, Line 21: fro
> nit:for
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jun 2019 20:51:16 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Adjust storage handler package

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

LGTM, just nits.

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG@7
PS1, Line 7: [hms] Adjust storage handler package
> It doesn't really enable KUDU-442 even though it's forward looking for it. 
Sounds good.


http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG@9
PS4, Line 9: This patch changes the new KuduStorageHandler
I think it is worth mentioning that this patch is not using the new KuduStorageHandler yet(to not break impala tests), but to add support for it. The follow up patch will actually adopt the new KuduStorageHandler and remove the old one.


http://gerrit.cloudera.org:8080/#/c/13540/4//COMMIT_MSG@21
PS4, Line 21: fro
nit:for



-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 Jun 2019 20:44:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13540

to look at the new patch set (#2).

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support fro the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 33 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG@7
PS1, Line 7: [hms] Adjust storage handler package
nit: maybe add the Kudu jira KUDU-442 to the commit msg?



-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:07:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13540

to look at the new patch set (#3).

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support fro the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 33 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jun 2019 18:08:51 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 1:

This should be coordinated with https://issues.apache.org/jira/browse/IMPALA-8629


-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jun 2019 17:15:23 +0000
Gerrit-HasComments: No

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 )

Change subject: [hms] Adjust storage handler package
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13540/1//COMMIT_MSG@7
PS1, Line 7: [hms] Adjust storage handler package
> nit: maybe add the Kudu jira KUDU-442 to the commit msg?
It doesn't really enable KUDU-442 even though it's forward looking for it. I would rather just leave it as is if that's okay.



-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 06 Jun 2019 19:55:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13540

to look at the new patch set (#5).

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support for the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 32 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/5
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [hms] Adjust storage handler package
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13540

to look at the new patch set (#4).

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support fro the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 32 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13540

to look at the new patch set (#6).

Change subject: [hms] Adjust storage handler package
......................................................................

[hms] Adjust storage handler package

This patch changes the new KuduStorageHandler
package from “org.apache.kudu.hive” to
“org.apache.hadoop.hive.kudu”.

This is being done to ensure the stand-in storage handler
can be a real storage handler when a Hive integration
is added in the future. The “org.apache.hadoop.hive”
package is the standard package all Hive storage
handlers lives under.

Note: For the sake of including this into the Impala
project without breaking things, we temporarily
maintain support for the old storage handler. It will
be remvoed in a follow up commit before a release.

Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
---
M java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client.cc
M src/kudu/hms/hms_client.h
M src/kudu/master/hms_notification_log_listener.cc
5 files changed, 35 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/13540/6
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [hms] Adjust storage handler package

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: [hms] Adjust storage handler package
......................................................................


Removed Verified-1 by Grant Henke <gr...@apache.org>
-- 
To view, visit http://gerrit.cloudera.org:8080/13540
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I66b314c1c8b56785005d6e0d8b679e19219494fe
Gerrit-Change-Number: 13540
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)