You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by jo...@apache.org on 2008/12/04 00:35:19 UTC

svn commit: r723141 - /poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java

Author: josh
Date: Wed Dec  3 15:35:18 2008
New Revision: 723141

URL: http://svn.apache.org/viewvc?rev=723141&view=rev
Log:
Improvements to arg checking in constructor

Modified:
    poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java

Modified: poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java?rev=723141&r1=723140&r2=723141&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/LittleEndianByteArrayOutputStream.java Wed Dec  3 15:35:18 2008
@@ -30,9 +30,17 @@
 	private int _writeIndex;
 
 	public LittleEndianByteArrayOutputStream(byte[] buf, int startOffset, int maxWriteLen) {
+		if (startOffset < 0 || startOffset > buf.length) {
+			throw new IllegalArgumentException("Specified startOffset (" + startOffset 
+					+ ") is out of allowable range (0.." + buf.length + ")");
+		}
 		_buf = buf;
 		_writeIndex = startOffset;
 		_endIndex = startOffset + maxWriteLen;
+		if (_endIndex < startOffset ||  _endIndex > buf.length) {
+			throw new IllegalArgumentException("calculated end index (" + _endIndex 
+					+ ") is out of allowable range (" + _writeIndex + ".." + buf.length + ")");
+		}
 	}
 	public LittleEndianByteArrayOutputStream(byte[] buf, int startOffset) {
 		this(buf, startOffset, buf.length - startOffset);
@@ -91,7 +99,7 @@
 	}
 	public LittleEndianOutput createDelayedOutput(int size) {
 		checkPosition(size);
-		LittleEndianOutput result = new LittleEndianByteArrayOutputStream(_buf, _writeIndex, _writeIndex+size);
+		LittleEndianOutput result = new LittleEndianByteArrayOutputStream(_buf, _writeIndex, size);
 		_writeIndex += size;
 		return result;
 	}



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org