You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/16 18:49:28 UTC

[GitHub] [spark] khalidmammadov commented on a diff in pull request #38273: [SPARK-37945][SQL][CORE] Use error classes in the execution errors of arithmetic ops

khalidmammadov commented on code in PR #38273:
URL: https://github.com/apache/spark/pull/38273#discussion_r996479467


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -256,6 +256,11 @@
     ],
     "sqlState" : "22008"
   },
+  "DECIMAL_PRECISION_EXCEEDS_MAX_PRECISION" : {

Review Comment:
   @amaliujia apart from INTEGER_OVERFLOW rest of the changes are merely replacing name for the existing class metaname
   @MaxGekk all of these are already unit tested within relevant use cases via **intercept[]** but I can work on changing those cases to assert additionally the class name/msg using  **checkError( ... errorClass="CLASS_NAME")**  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org