[GitHub] [dubbo] BurningCN commented on a change in pull request #8783: Optimize some code of the dubbo metadata module

[GitBox <gi...@apache.org>]

BurningCN commented on a change in pull request #8783:
URL: https://github.com/apache/dubbo/pull/8783#discussion_r707236278



##########
File path: dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/support/AbstractMetadataReport.java
##########
@@ -102,11 +105,9 @@
     public AbstractMetadataReport(URL reportServerURL) {
         setUrl(reportServerURL);
         // Start file save timer
-        String defaultFilename = System.getProperty("user.home") +
-                "/.dubbo/dubbo-metadata-" +
-                reportServerURL.getApplication() + "-" +
-                replace(reportServerURL.getAddress(), ":", "-") +
-                ".cache";
+        String defaultFilename = System.getProperty(USER_HOME) + DUBBO_METADATA_KEY +

Review comment:
       According to the context, the name of the constant should not be XX_KEY, right?
   DUBBO_METADATA_KEY & CACHE_KEY




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org